Skip to content

fix: include label in templates when adding by cli #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Jul 10, 2024
Merged

fix: include label in templates when adding by cli #5682

k8s-ci-robot merged 2 commits into from
Jul 10, 2024

Conversation

@kozjan
Copy link
Contributor

@kozjan kozjan commented Apr 26, 2024

Related to this comment: #1009 (comment)

added --include-templates to add labels to templates when using kustomize edit add label

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 26, 2024

Welcome @kozjan!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 26, 2024

Hi @kozjan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
stormqueen1990
stormqueen1990 reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @kozjan! 👋🏻

Thank you for your contribution!

This looks mostly good to me. However, this implementation requires --without-selector to be specified and there's no added validation for that. Could you please update validateAndParse to ensure that any invocation of kustomize edit add label --include-templates fails when --without-selector is not specified, as well as an extra test case for that scenario?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2024

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@kozjan
Copy link
Contributor Author

kozjan commented May 10, 2024

Hi there, @kozjan! 👋🏻

Thank you for your contribution!

This looks mostly good to me. However, this implementation requires --without-selector to be specified and there's no added validation for that. Could you please update validateAndParse to ensure that any invocation of kustomize edit add label --include-templates fails when --without-selector is not specified, as well as an extra test case for that scenario?

@stormqueen1990
hey, can you check it out again?

stormqueen1990
stormqueen1990 reviewed May 17, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@varshaprasad96
Copy link
Member

varshaprasad96 commented May 17, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 21, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 21, 2024
@stormqueen1990
Copy link
Member

stormqueen1990 commented May 21, 2024

/easycla

@stormqueen1990
Copy link
Member

stormqueen1990 commented May 21, 2024

Hi there, @kozjan! It looks like there was a lint failure, could you please take a look at that?

It also seems like EasyCLA couldn't pick up the commit identity correctly for the commit made via GitHub CLI. It might be a good idea to squash the commits and see if that works.

@kozjan kozjan force-pushed the add-label-include-templates branch from c85ee43 to cba3688 Compare June 6, 2024 12:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 6, 2024
@kozjan
Copy link
Contributor Author

kozjan commented Jun 6, 2024

Hi there, @kozjan! It looks like there was a lint failure, could you please take a look at that?

It also seems like EasyCLA couldn't pick up the commit identity correctly for the commit made via GitHub CLI. It might be a good idea to squash the commits and see if that works.

hey @stormqueen1990, sorry for getting back so late
I squashed review fixes + lint fix into last commit.

stormqueen1990
stormqueen1990 reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
varshaprasad96
varshaprasad96 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!
/lgtm
/approve

@stormqueen1990 could you please add a lgtm before merging?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kozjan, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 735ad0b into kubernetes-sigs:master Jul 10, 2024
@stormqueen1990 stormqueen1990 mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@ncapps ncapps Awaiting requested review from ncapps

+1 more reviewer

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stormqueen1990 stormqueen1990

@varshaprasad96 varshaprasad96

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kozjan @k8s-ci-robot @varshaprasad96 @stormqueen1990