update dependencies google.golang.org/[email protected] #5615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
koba1t
deleted the
update_dependencies_google.golang.org/protobuf_to_v1.33.0
branch
thaJeztah
reviewed
Jan 3, 2025
Comment on lines
-18
to
+19
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect |
Contributor
There was a problem hiding this comment.
Why were these updated to non-released versions? They're not even a dependency go protobuf?
https://github.com/protocolbuffers/protobuf-go/blob/v1.33.0/go.mod#L5-L10
This caused a massive ripple effect in any project having a dependency on kustomize or kubernetes (direct or indirect) 😞
This was referenced Jan 3, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to google.golang.org/[email protected] due to security reasons.
for example https://github.com/kubernetes-sigs/kustomize/security/dependabot/331