Skip to content

kustomize build {repoUrl} - #248

Closed
Liujingfang1 wants to merge 2 commits into
kubernetes-sigs:masterfrom
Liujingfang1:repoUrl
Closed

Liujingfang1 wants to merge 2 commits into
kubernetes-sigs:masterfrom
Liujingfang1:repoUrl

Conversation

@Liujingfang1

@Liujingfang1 Liujingfang1 commented Aug 13, 2018 •

Copy link
Copy Markdown
Contributor

Fix #32

Current implementation supports

  • build a remote GitHub repo with a root level kustomization
  • build a kustomization from a subdirectory in a remote GitHub repo

The format supported is
https://github.com/kubernetes-sigs/kustomize/<directory>#<branch/commit/tag>

  • directory is optional
  • branch/commit/tag is optional

For example:
kustomize build https://github.com/project/myrepo#v1.0.0
will do

git clone https://github.com/project/myrepo   /tmp/a-tmp-dir
git checkout v1.0.0
kustomize build /tmp/a-tmp-dir

kustomize build https://github.com/project/myrepo/variants/staging#v1.0.0
will do

git clone https://github.com/project/myrepo   /tmp/a-tmp-dir
git checkout v1.0.0
kustomize build /tmp/a-tmp-dir/variants/staging

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2018
@k8s-ci-robot
k8s-ci-robot requested review from droot and mengqiy August 13, 2018 17:31
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2018
@Liujingfang1
Liujingfang1 removed the request for review from droot August 13, 2018 17:31
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2018
@Liujingfang1
Liujingfang1 requested review from droot, mengqiy and monopole and removed request for mengqiy August 13, 2018 17:31
@Liujingfang1 Liujingfang1 changed the title WIP: kustomize build {repoUrl} kustomize build {repoUrl} Aug 13, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2018
@Liujingfang1

Copy link
Copy Markdown
Contributor Author

The change is ready for review. Please take a look

@Liujingfang1

Copy link
Copy Markdown
Contributor Author

Will create a new PR for this using go-getter

@Liujingfang1
Liujingfang1 deleted the repoUrl branch September 6, 2018 18:42
@dvaldivia

Copy link
Copy Markdown

Did the way this change works changed? I'm trying to build a repo#tag and I keep getting an error on kustomize 3.8.1

➜ kustomize build https://github.com/minio/operator/\#v3.0.1                      
Error: evalsymlink failure on '/private/var/folders/24/lvzqkl3d23n_b4h_sb480_100000gn/T/kustomize-763649146/#v3.0.1' : lstat /private/var/folders/24/lvzqkl3d23n_b4h_sb480_100000gn/T/kustomize-763649146/#v3.0.1: no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kustomize build {repoUrl}

3 participants