Skip to content

🌱 (go/v4): Assert domain is preserved when external flags are not re-supplied - #5924

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
tanayarun:webhook-test-assert-domain
Jul 27, 2026
Merged

🌱 (go/v4): Assert domain is preserved when external flags are not re-supplied#5924
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
tanayarun:webhook-test-assert-domain

Conversation

@tanayarun

@tanayarun tanayarun commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Closes #5922

The test "should retain path for existing external resource without
re-providing --external-api-path" asserted External and Path after
InjectResource, but not Domain.

InjectResource copies Path/Plural/External/Core/Module from the stored
resource but never reassigns Domain on the caller's resource pointer,
so Domain should remain unchanged (testIO) through the call.

@kubernetes-prow
kubernetes-prow Bot requested a review from camilamacedo86 July 27, 2026 15:09
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from varshaprasad96 July 27, 2026 15:09
@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Hi @tanayarun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2026
camilamacedo86
camilamacedo86 approved these changes Jul 27, 2026
View reviewed changes

@camilamacedo86 camilamacedo86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tanayarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026
@camilamacedo86

camilamacedo86 commented Jul 27, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit d9dafa9 into kubernetes-sigs:master Jul 27, 2026
19 checks passed
@camilamacedo86 camilamacedo86 mentioned this pull request Aug 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes
@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create webhook test: also assert the domain is preserved when external flags are not re-supplied

2 participants

@tanayarun @camilamacedo86