Skip to content

🐛 (helm/v2-alpha): fix edit hang on malformed dist/install.yaml - #5753

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
tanayarun:fix/helm-v2alpha-hang-malformed-yaml
Jun 14, 2026
Merged

🐛 (helm/v2-alpha): fix edit hang on malformed dist/install.yaml#5753
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
tanayarun:fix/helm-v2alpha-hang-malformed-yaml

Conversation

@tanayarun

@tanayarun tanayarun commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Replace continue with break in the extractNamespaceFromManifests decode loop.

The yaml/v3 decoder returns the same error repeatedly after a parse failure,
so continue caused an infinite loop when dist/install.yaml was malformed.
Using break instead bails out and falls back to the default namespace
(<project>-system), which is the behaviour already used in other failure
cases in the same function.

Also adds three tests in edit_test.go covering the malformed YAML case
(regression), the happy path, and the missing file path.

Fixes #5750

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: tanayarun / name: tanayarun (a08c8c6)

@k8s-ci-robot

k8s-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Welcome @tanayarun!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2026
@k8s-ci-robot

k8s-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Hi @tanayarun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 11, 2026
@camilamacedo86

camilamacedo86 commented Jun 14, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2026
camilamacedo86
camilamacedo86 approved these changes Jun 14, 2026
View reviewed changes

@camilamacedo86 camilamacedo86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2026
@k8s-ci-robot

k8s-ci-robot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tanayarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2026
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 14, 2026
Closed
@k8s-ci-robot
k8s-ci-robot merged commit 8976e4c into kubernetes-sigs:master Jun 14, 2026
19 checks passed
@tanayarun

tanayarun commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review and merge @camilamacedo86

@cmcognition

cmcognition commented Jun 19, 2026

Copy link
Copy Markdown

@tanayarun

Thx for the nice work !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes
@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96
@vitorfloriano vitorfloriano Awaiting requested review from vitorfloriano

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(helm/v2-alpha) kubebuilder edit hangs forever if dist/install.yaml is malformed

4 participants

@tanayarun @k8s-ci-robot @camilamacedo86 @cmcognition