Skip to content

fix: Duplicate kubelet parameter by automatic resource sizing script#1717

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
ffais:fix-resource-sizing-script
Apr 21, 2025
Merged

fix: Duplicate kubelet parameter by automatic resource sizing script#1717
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
ffais:fix-resource-sizing-script

Conversation

@ffais
Copy link
Copy Markdown
Contributor

@ffais ffais commented Apr 18, 2025

Change description

Fixes duplicate --system-reserved Kubelet parameter added by automatic resource sizing script when is executed multiple times.

Related issues

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2025

Hi @ffais. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2025
@AverageMarcus
Copy link
Copy Markdown
Member

AverageMarcus commented Apr 21, 2025

/ok-to-test
/lgtm
/assign @mboersma

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2025
mboersma
mboersma approved these changes Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6f0f5a0 into kubernetes-sigs:main Apr 21, 2025
9 checks passed
@ffais ffais deleted the fix-resource-sizing-script branch April 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate kubelet parameter by automatic resource sizing script

5 participants

@ffais @k8s-ci-robot @AverageMarcus @mboersma @mbrow137