Repository navigation
Substrate overlay: register CSIDriverConfig as ate.dev/v1 - #1420
Merged
kubernetes-prow[bot] merged 1 commit intoNov 4, 2026
Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-prow[bot] merged 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Substrate moved its CRDs from
ate.dev/v1alpha1toate.dev/v1in agent-substrate/substrate#2996 (merged 2026-10-23). The move has no overlap window: v1.0.0-rc.1 and later serve onlyate.dev/v1, so applying the Substrate overlay'sCSIDriverConfigfails on current Substrate releases (no matches for kind "CSIDriverConfig" in version "ate.dev/v1alpha1").The
csidriverconfigs.ate.devschema is the same apart from the version name: diffing the generated CRD before and after #2996 shows onlyname: v1alpha1→name: v1, and Substratemainstill matches. Every field the overlay sets (driverName,controllerEndpoint,nodeSocketOverride,tls.{enabled,serverName,usePodIdentity}) is in thev1schema, so the only change needed is theapiVersion.csi_driver_config.yaml:apiVersion: ate.dev/v1. The TODO is replaced with a note on which Substrate releases serve which version.README.md: the overlay table namesate.dev/v1and the Substrate release it needs.Which issue(s) this PR fixes:
Fixes #1416
Special notes for your reviewer:
ate.dev/v1alpha1, and the CRD has no conversion between the two.kubectl kustomize deploy/kubernetes/overlays/substraterenders theCSIDriverConfigasate.dev/v1. To render it outsidedeploy.sh, I generatedserviceaccount_patch.yamlfrom its template with a placeholder.deploy.shsilently skips theroles/file.editorgrant when it has just created the service account.Does this PR introduce a user-facing change?: