Skip to content

Substrate overlay: register CSIDriverConfig as ate.dev/v1 - #1420

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
MushuEE:substrate-overlay-ate-dev-v1
Nov 4, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
MushuEE:substrate-overlay-ate-dev-v1

Conversation

@MushuEE

@MushuEE MushuEE commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Substrate moved its CRDs from ate.dev/v1alpha1 to ate.dev/v1 in agent-substrate/substrate#2996 (merged 2026-10-23). The move has no overlap window: v1.0.0-rc.1 and later serve only ate.dev/v1, so applying the Substrate overlay's CSIDriverConfig fails on current Substrate releases (no matches for kind "CSIDriverConfig" in version "ate.dev/v1alpha1").

The csidriverconfigs.ate.dev schema is the same apart from the version name: diffing the generated CRD before and after #2996 shows only name: v1alpha1 → name: v1, and Substrate main still matches. Every field the overlay sets (driverName, controllerEndpoint, nodeSocketOverride, tls.{enabled,serverName,usePodIdentity}) is in the v1 schema, so the only change needed is the apiVersion.

  • csi_driver_config.yaml: apiVersion: ate.dev/v1. The TODO is replaced with a note on which Substrate releases serve which version.
  • README.md: the overlay table names ate.dev/v1 and the Substrate release it needs.

Which issue(s) this PR fixes:

Fixes #1416

Special notes for your reviewer:

  • Compatibility: after this change the overlay needs Substrate v1.0.0-rc.1 or later. Substrate v0.6.0 and earlier serve only ate.dev/v1alpha1, and the CRD has no conversion between the two.
  • Verified: kubectl kustomize deploy/kubernetes/overlays/substrate renders the CSIDriverConfig as ate.dev/v1. To render it outside deploy.sh, I generated serviceaccount_patch.yaml from its template with a placeholder.
  • Not yet run against a live cluster.
  • Related, not changed here: Substrate overlay: deploy.sh silently skips the roles/file.editor grant when it has just created the service account #1417, where deploy.sh silently skips the roles/file.editor grant when it has just created the service account.

Does this PR introduce a user-facing change?:

action required: The Substrate overlay's CSIDriverConfig now uses ate.dev/v1, which Substrate v1.0.0-rc.1 and later require. Deploying the overlay on Substrate v0.6.0 or earlier is no longer supported.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment