Repository navigation
fix: swap inverted pod add and update log messages - #3013
Conversation
PodUpdateOrAddIfNotExist returns false when an endpoint was not already present and true when every endpoint already existed. updateDatastore logs these the wrong way round, reporting "Pod added" for an update and "Pod already exists" for a genuine add. Log text only, no behaviour change. Signed-off-by: Kush Zingade <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @UgaTheDev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, UgaTheDev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rebase |
|
/retest |
|
@UgaTheDev to fix Trivy, we need to update https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/go.mod#L100 to 0.39.0 |
Trivy flags golang.org/x/text v0.37.0 for CVE-2026-56852, a HIGH severity denial of service, fixed in 0.39.0. The sibling golang.org/x modules move with it because v0.39.0 requires newer versions of them, so minimal version selection resolves crypto, mod, net, sys, term and tools up as well. Signed-off-by: Kush Zingade <[email protected]>
|
Done, pushed. Trivy was flagging CVE-2026-56852 in One thing worth a look before merging: bumping it also moves the sibling
|
|
/lgtm |
updateDatastorelogs the result ofPodUpdateOrAddIfNotExistbackwards.The datastore sets its return value to
falsewhen an endpoint was not already present, and leaves ittruewhen every endpoint already existed:The current branches therefore log "Pod added" for an update and "Pod already exists" for a genuine add.
This swaps the two messages. Log text only, no behaviour change.
pkg/lwepp/controller/pod_reconciler.gois the only consumer of the return value.