Skip to content

Conversation

@LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Dec 1, 2025

What type of PR is this?
/kind test
/area conformance-test

What this PR does / why we need it:
Last mile of #4138 (Thanks @ciarams87!)

Which issue(s) this PR fixes:

Fixes #4101

Does this PR introduce a user-facing change?:

Fix slow conformance XRoute weight conformance tests

ciarams87 and others added 3 commits September 30, 2025 13:35
The mesh weight conformance tests were executing 500 separate kubectl exec
commands with random delays, resulting in very slow test execution. This
optimization uses the echo client's --count flag to execute all 500 requests
in a single batch, dramatically reducing test time.
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2025
@LiorLieberman LiorLieberman changed the title Conformance fix Optimize mesh (GRPC|HTTP)RouteWeight tests Dec 2, 2025
@LiorLieberman LiorLieberman marked this pull request as ready for review December 2, 2025 17:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from candita December 2, 2025 17:03
@kflynn
Copy link
Contributor

kflynn commented Dec 2, 2025

Looks sane, looking for another approval.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

robscott commented Dec 2, 2025

Thanks @ciarams87 and @LiorLieberman!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7420437 into kubernetes-sigs:main Dec 2, 2025
44 checks passed
@kflynn
Copy link
Contributor

kflynn commented Dec 3, 2025

/cherry-pick release-1.4

🤞 😂

@k8s-infra-cherrypick-robot
Copy link
Contributor

@kflynn: new pull request created: #4307

In response to this:

/cherry-pick release-1.4

🤞 😂

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kflynn
Copy link
Contributor

kflynn commented Dec 3, 2025

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link
Contributor

@kflynn: new pull request created: #4315

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.4.0: new conformance tests are too slow

6 participants