-
Notifications
You must be signed in to change notification settings - Fork 634
Optimize mesh (GRPC|HTTP)RouteWeight tests #4300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize mesh (GRPC|HTTP)RouteWeight tests #4300
Conversation
The mesh weight conformance tests were executing 500 separate kubectl exec commands with random delays, resulting in very slow test execution. This optimization uses the echo client's --count flag to execute all 500 requests in a single batch, dramatically reducing test time.
|
Skipping CI for Draft Pull Request. |
|
Looks sane, looking for another approval. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @ciarams87 and @LiorLieberman! /lgtm |
|
/cherry-pick release-1.4 🤞 😂 |
|
@kflynn: new pull request created: #4307 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.4 |
|
@kflynn: new pull request created: #4315 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
Last mile of #4138 (Thanks @ciarams87!)
Which issue(s) this PR fixes:
Fixes #4101
Does this PR introduce a user-facing change?: