-
Notifications
You must be signed in to change notification settings - Fork 632
[release-1.4] Make single TargetRef Core for BackendTLSPolicy #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] Make single TargetRef Core for BackendTLSPolicy #4298
Conversation
Make Core conformance for BackendTLSPolicy only support a single TargetRef for now, while we figure out what to do about representing some edge cases in status. Signed-off-by: Nick Young <[email protected]>
|
/lgtm |
|
oh damn, this is the broken report from airlock :/ |
|
I'll rebase once #4299 merges. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
…(#224) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [kubernetes-sigs/gateway-api](https://github.com/kubernetes-sigs/gateway-api) | Kustomization | patch | `v1.4.0` -> `v1.4.1` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/gateway-api (kubernetes-sigs/gateway-api)</summary> ### [`v1.4.1`](https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.4.1) [Compare Source](kubernetes-sigs/gateway-api@v1.4.0...v1.4.1) **Warning**: Regarding the **Experimental CRDs** - please note that the experimental CRDs for this release are too large for a standard `kubectl apply`. You may receive an error like `metadata.annotations: Too long: may not be more than 262144 bytes`. To work around this please use `kubectl apply --server-side -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.4.0/experimental-install.yaml`. We're looking into ways to reduce the size for future releases to avoid this. #### Changes Since v1.4.0 ##### BackendTLSPolicy - BackendTLSPolicy supports only a single `targetRef` per policy while Gateway API works through edge cases around representing the status of multiple `targetRefs` in a single policy. This restriction is expected to be lifted in a future release. ([#​4316], [#​4298]) - SAN validation in BackendTLSPolicy is correctly marked as standard. ([#​4194]) - BackendTLSPolicy `status` is correctly marked as a subresource. ([#​4245]) ##### Conformance - Conformance tests for mesh routing with weights have been made faster. ([#​4315]) - BackendTLSPolicy conformance tests are included in the GATEWAY-HTTP profile. ([#​4223]) ##### Thanks to [Ciara Stacke], [Lior Lieberman], [Nick Young], [Norwin Schnyder], [Ricardo Pchevuzinske Katz], and [zirain] [Ciara Stacke]: https://github.com/ciarams87 [Lior Lieberman]: https://github.com/LiorLieberman [Nick Young]: https://github.com/youngnick [Norwin Schnyder]: https://github.com/snorwin [Ricardo Pchevuzinske Katz]: https://github.com/rikatz [zirain]: https://github.com/zirain [#​4194]: kubernetes-sigs/gateway-api#4194 [#​4223]: kubernetes-sigs/gateway-api#4223 [#​4245]: kubernetes-sigs/gateway-api#4245 [#​4298]: kubernetes-sigs/gateway-api#4298 [#​4315]: kubernetes-sigs/gateway-api#4315 [#​4316]: kubernetes-sigs/gateway-api#4316 #### Full Changelog **Full Changelog**: <kubernetes-sigs/gateway-api@v1.4.0...v1.4.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNy4xIiwidXBkYXRlZEluVmVyIjoiNDIuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This is an automated cherry-pick of #4296
/assign youngnick