Skip to content

Make single TargetRef Core for BackendTLSPolicy #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 1, 2025
Merged

Make single TargetRef Core for BackendTLSPolicy #4296

k8s-ci-robot merged 1 commit into from
Dec 1, 2025

Conversation

@youngnick
Copy link
Contributor

@youngnick youngnick commented Dec 1, 2025

Make Core conformance for BackendTLSPolicy only support a single TargetRef for now, while we figure out what to do about representing some edge cases in status.

/kind cleanup
/kind documentation

Does this PR introduce a user-facing change?:

BackendTLSPolicy now only supports a single TargetRef in Core conformance. This is temporary while we define some edge case behavior.

@youngnick
Make single TargetRef Core for BackendTLSPolicy
e0dae2f 
Make Core conformance for BackendTLSPolicy only support
a single TargetRef for now, while we figure out what to
do about representing some edge cases in status.

Signed-off-by: Nick Young <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@kflynn
Copy link
Contributor

kflynn commented Dec 1, 2025

/lgtm

Thanks @youngnick!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
@youngnick
Copy link
Contributor Author

youngnick commented Dec 1, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2025
@youngnick
Copy link
Contributor Author

youngnick commented Dec 1, 2025

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 1, 2025

@youngnick: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit d2cd601 into kubernetes-sigs:main Dec 1, 2025
20 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 1, 2025

@youngnick: new pull request created: #4298

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@robscott robscott Awaiting requested review from robscott

Assignees

@kflynn kflynn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youngnick @k8s-ci-robot @kflynn @k8s-infra-cherrypick-robot