Skip to content

Ignore generated implementations docs #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Nov 22, 2025
Merged

Ignore generated implementations docs #4263

k8s-ci-robot merged 2 commits into from
Nov 22, 2025
+1 −320

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Nov 22, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This follows up #4225.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 22, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2025

Hi @tisonkun. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tisonkun tisonkun mentioned this pull request Nov 22, 2025
Closed
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2025
@tisonkun
Copy link
Contributor Author

tisonkun commented Nov 22, 2025

Tested locally that make live-docs can properly generate these files.

@rikatz
Copy link
Member

rikatz commented Nov 22, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2025
@rikatz
Copy link
Member

rikatz commented Nov 22, 2025

@youngnick we need someone to click on "approve workflows to run".

@robscott @shaneutt we need to fix these permissions on gh actions

other than that, lgtm, I have checked the generated site and it is fine. Will leave lgtm for after the workflow

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tisonkun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2025
@robscott
Copy link
Member

robscott commented Nov 22, 2025

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit b9c6f3c into kubernetes-sigs:main Nov 22, 2025
20 checks passed
@tisonkun tisonkun deleted the ignore-site-docs branch November 23, 2025 08:45
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@tisonkun @tylerauerbeck
Ignore generated implementations docs (kubernetes-sigs#4263)
1c71a59 
* Ignore generated implementations docs

Signed-off-by: tison <[email protected]>

* do remove

Signed-off-by: tison <[email protected]>

---------

Signed-off-by: tison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tisonkun @k8s-ci-robot @rikatz @robscott