Skip to content

Fix gke-gateway conformance report 1.3 filename #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Nov 4, 2025
Merged

Fix gke-gateway conformance report 1.3 filename #4221

k8s-ci-robot merged 2 commits into from
Nov 4, 2025
+1 −1

Conversation

@syw14
Copy link
Contributor

@syw14 syw14 commented Nov 3, 2025

What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
Put the wrong filename in conformance report 1.3 which causes confusion mismatching the actual gatewayClass (listed in mode) used running the conformance test.

Which issue(s) this PR fixes:
n/a

Does this PR introduce a user-facing change?:
n/a

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

Hi @syw14. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@syw14
Copy link
Contributor Author

syw14 commented Nov 3, 2025

@robscott thanks!

robscott
robscott reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @syw14!

@syw14 syw14 requested a review from robscott November 3, 2025 23:47
@robscott
Copy link
Member

robscott commented Nov 4, 2025

Thanks @syw14!

/lgtm
/approve
/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, syw14

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit de07024 into kubernetes-sigs:main Nov 4, 2025
8 checks passed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@syw14 @tylerauerbeck
Fix gke-gateway conformance report 1.3 filename (kubernetes-sigs#4221)
9a7bef6 
* Fix gke-gateway conformance report 1.3 filename

* Rename the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn Awaiting requested review from howardjohn

@mikemorris mikemorris Awaiting requested review from mikemorris

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syw14 @k8s-ci-robot @robscott