-
Notifications
You must be signed in to change notification settings - Fork 632
Add a docs team #4203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a docs team #4203
Conversation
hack/mkdocs/OWNERS
Outdated
| reviewers: | ||
| - gateway-api-maintainers | ||
| - gateway-api-mesh-leads | ||
| - gateway-api-doc-approvers No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Mind adding trailing new line here and in other file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my damn linter keeps removing it, hold on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
5c23196 to
d551278
Compare
|
Is there any way to tie it to just PRs tagged as /lgtm |
not that I am aware off, looking into prow plugins :( |
|
Thanks @rikatz! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds a new entry into Gateway API owners, creating a new docs team. These contributors will be responsible for docs improvements (review, approval) as so on automation of templates, generation of pages, etc.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: