Skip to content

Docs: Update GEP-1294 to document ServiceImport as backendRef (#4185) #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 20, 2025
Merged

Docs: Update GEP-1294 to document ServiceImport as backendRef (#4185) #4186

k8s-ci-robot merged 1 commit into from
Oct 20, 2025

Conversation

@kahirokunn
Copy link
Member

@kahirokunn kahirokunn commented Oct 17, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Documents that ServiceImport may be used as a backendRef in GEP-1294, aligned with GEP-1748 semantics. This clarifies MCS interoperability (e.g., ClusterSetIP) for mesh/East-West traffic splitting and explicitly notes that headless ServiceImport is out of scope.

  • Add a new subsection “ServiceImport as backendRef” under “Allowed service types” in geps/gep-1294/index.md
  • State that support is optional, MUST follow GEP-1748 semantics when implemented
  • Clarify that headless ServiceImport is not in scope
  • No API/schema changes; documentation-only

Which issue(s) this PR fixes:
Fixes #4185

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2025
@kahirokunn
Copy link
Member Author

kahirokunn commented Oct 17, 2025

Hi @youngnick ✋
when you have a moment, could you please review this PR? Your feedback would be greatly appreciated. Thank you!

@kflynn
Copy link
Contributor

kflynn commented Oct 17, 2025

/approve

Leaving the final LGTM for Nick or another maintainer...

@kahirokunn
Copy link
Member Author

kahirokunn commented Oct 20, 2025

@youngnick Hello! Could you please review this? 🙏

@mikemorris
Copy link
Contributor

mikemorris commented Oct 20, 2025

/lgtm

For clarity, this isn't introducing any new functionality - this is already covered in https://gateway-api.sigs.k8s.io/geps/gep-1294/#extended-conformance and just clarifies the docs by listing it explicitly rather than buried in prose in the next section.

(If other reviewers want to reword/remove that following section as redundant that could be fine too.)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@robscott
Copy link
Member

robscott commented Oct 20, 2025

Thanks @kahirokunn!

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kahirokunn, kflynn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit de5f3e6 into kubernetes-sigs:main Oct 20, 2025
20 checks passed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@kahirokunn @tylerauerbeck
Docs: Update GEP-1294 to document ServiceImport as backendRef (kubern…
b621cf7 
…etes-sigs#4185) (kubernetes-sigs#4186)

Signed-off-by: kahirokunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kflynn kflynn Awaiting requested review from kflynn

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@mikemorris mikemorris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify ServiceImport as a permissible backendRef in GEP-1294

5 participants

@kahirokunn @kflynn @mikemorris @robscott @k8s-ci-robot