Docs: Adds CRD Install Workaround #4174
Conversation
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/XS
|
|
||
| ```bash | ||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.4.0/standard-install.yaml | ||
| kubectl apply --server-side -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.4.0/standard-install.yaml |
There was a problem hiding this comment.
I don't think this is strictly required for standard channel yet, but seems like an improvement anyway.
site-src/guides/index.md
Outdated
| kubectl apply --server-side -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.4.0/standard-install.yaml | ||
| ``` | ||
|
|
||
| **Note:** Remove `--server-side` from the above command when [Issue 4156](https://github.com/kubernetes-sigs/gateway-api/issues/4156) is fixed. |
There was a problem hiding this comment.
If there's general agreement that this flag achieves a better result, maybe we should omit these notes and make this a more permanent change?
There was a problem hiding this comment.
+1
I would prefer to permanently keep the flag and avoid future problems
There was a problem hiding this comment.
I really can't think of a reason that we wouldn't want to steer people to server-side apply in all cases. (I actually switched my client defaults to always use it.)
There was a problem hiding this comment.
Agreed. I think we should ideally link folks to the instructions for changing client defaults as well.
There was a problem hiding this comment.
Commit 4ee0c24 keeps server-side apply for both channels and replaces the **Note** with a reference to the upstream server-side apply docs in case the reader needs to learn more about this option.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM but I'll give @danehans a chance to remove the notes and/or link the client defaults doc page. |
Signed-off-by: Daneyon Hansen <[email protected]>
k8s-ci-robot
added
size/S
|
Ship it! 🙂 /lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Daneyon Hansen <[email protected]>
6 participants
Adds
--server-sideto the kubectl apply commands in the install guide.What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds the workaround from #4156 until this issue is fixed.
Which issue(s) this PR fixes:
Fixes #4173
Does this PR introduce a user-facing change?: