Skip to content

Conversation

@shaneutt
Copy link
Member

@shaneutt shaneutt commented Oct 6, 2025

This merges in the consts.go and documentation changes from the release-v1.4 branch for consistency.

Once this merges, I'll close the milestone officially.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2025
@shaneutt shaneutt removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2025
@shaneutt shaneutt moved this to Review in Release v1.4.0 Oct 6, 2025
@shaneutt shaneutt added this to the v1.4.0 milestone Oct 6, 2025
@shaneutt shaneutt linked an issue Oct 6, 2025 that may be closed by this pull request
@shaneutt shaneutt self-assigned this Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2025
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 6, 2025
@rikatz
Copy link
Member

rikatz commented Oct 6, 2025

/lgtm
/hold
(If you want to wait for someone else).

Did a double check here, all the references of 1.3.0 seem to be updated to 1.4.0, thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@kflynn
Copy link
Contributor

kflynn commented Oct 6, 2025

/lgtm

Thanks! 🙂

@stmcginnis
Copy link

/lgtm

@robscott
Copy link
Member

robscott commented Oct 6, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1cf7222 into kubernetes-sigs:main Oct 6, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Release v1.4.0 Oct 6, 2025
@shaneutt shaneutt deleted the merge-in branch October 6, 2025 17:00
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
* chore: update consts.go for v1.4.0

Signed-off-by: Shane Utt <[email protected]>

* chore: run generators

Signed-off-by: Shane Utt <[email protected]>

* docs: bump main guide for v1.4.0 release

Signed-off-by: Shane Utt <[email protected]>

* docs: bump README.md for v1.4.0 release

Signed-off-by: Shane Utt <[email protected]>

* docs: update nav for v1.4.0

Signed-off-by: Shane Utt <[email protected]>

---------

Signed-off-by: Shane Utt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Release v1.4.0

6 participants