Removing experimental annotation from SupportedFeatures in GWC Status. #4115
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-ok-to-test
|
Hi @bexxmodd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @LiorLieberman |
| // +optional | ||
| // +listType=map | ||
| // +listMapKey=name | ||
| // <gateway:experimental> |
There was a problem hiding this comment.
This needs a corresponding make generate or hack/update-codegen.sh (a subset of the former).
There was a problem hiding this comment.
Added make generate files.
|
Thanks @bexxmodd! /ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bexxmodd, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM once the |
|
@robscott @youngnick Added generated files, PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@shaneutt this is targeting release 1.4 FYI. Any label that needs to be added? |
|
/cherry-pick release-1.4 |
|
@robscott: new pull request created: #4116 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-sigs#4115) * Removing experimental annotation from supportedFeatures in GWC Status. * Run make generate to update generated files
6 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
SupportedFeatures is now
Which issue(s) this PR fixes:
Removing experimental annotation means that the Standard channel CRD (standard-install.yaml) will now include the SupportedFeatures field, confirming its graduation.
Fixes #4114
Does this PR introduce a user-facing change?: