Skip to content

Update GEP process docs with more details #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 1, 2025
Merged

Update GEP process docs with more details #4109

k8s-ci-robot merged 1 commit into from
Oct 1, 2025

Conversation

@youngnick
Copy link
Contributor

@youngnick youngnick commented Sep 22, 2025

/kind documentation

What this PR does / why we need it:
This commit updates the GEP process documentation
with some more information on what is required
to move between GEP states.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2025
@rikatz
Copy link
Member

rikatz commented Sep 22, 2025

/lgtm
unhold as you wish

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
@kflynn
Copy link
Contributor

kflynn commented Sep 23, 2025

Thanks @youngnick! I think this is a big win. 🙂

/approve

I'd like another maintainer to LGTM as well.

kflynn
kflynn reviewed Sep 23, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
robscott
robscott approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youngnick!

@youngnick
Update GEP process docs with more details
36be9d9 
This commit updates the GEP process documentation
with some more information on what is required
to move between GEP states.

Also updates the GEP template to match the documented
requirements for shifting levels.

Signed-off-by: Nick Young <[email protected]>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, robscott, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@youngnick
Copy link
Contributor Author

youngnick commented Sep 30, 2025

@robscott has reviewed, but is on leave now. I'm going to unhold this so that the next LGTM will merge it.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
@kflynn
Copy link
Contributor

kflynn commented Sep 30, 2025

@youngnick The GEP process changes look great here. 🙂 Are the changes to site-src/implementations/v1.2.md and site-src/implementations/v1.3.md intentional?

@kflynn
Copy link
Contributor

kflynn commented Oct 1, 2025

Ok, I chatted with @youngnick offline about this — the changes to site-src/implementations/v1.2.md and site-src/implementations/v1.3.md are there because checks were failing, seemingly from some other make generate that got missed. Nick’s plan is to drop those from version control and have them be generated on the fly at publish time, and I think that sounds like a fine plan so I’m good here. Thanks @youngnick!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit dd24e83 into kubernetes-sigs:main Oct 1, 2025
20 checks passed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@youngnick @tylerauerbeck
Update GEP process docs with more details (kubernetes-sigs#4109)
be91efe 
This commit updates the GEP process documentation
with some more information on what is required
to move between GEP states.

Also updates the GEP template to match the documented
requirements for shifting levels.

Signed-off-by: Nick Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kflynn kflynn kflynn left review comments

@robscott robscott robscott approved these changes

@candita candita Awaiting requested review from candita

@gcs278 gcs278 Awaiting requested review from gcs278

Assignees

@kflynn kflynn

@rikatz rikatz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@youngnick @rikatz @kflynn @k8s-ci-robot @robscott