Skip to content

Conversation

@howardjohn
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes #4102

Which issue(s) this PR fixes:

Fixes #4102

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kflynn September 18, 2025 18:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2025
@robscott
Copy link
Member

robscott commented Sep 19, 2025

Thanks @howardjohn!

/lgtm

I think this belongs in RC2 - will defer to @shaneutt for final call.
/cc @shaneutt

@robscott robscott added this to the v1.4.0 milestone Sep 19, 2025
@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2d40c3d into kubernetes-sigs:main Sep 19, 2025
20 checks passed
@shaneutt shaneutt moved this to Done in Release v1.4.0 Sep 19, 2025
shaneutt pushed a commit that referenced this pull request Sep 19, 2025
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

v1.4.0: regression in conformance test cleanup

3 participants