Skip to content

Added flag for running mesh conformance suite and automatically inferring supported features from Mesh.Status #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 6 commits into from
Sep 20, 2025
Merged

Added flag for running mesh conformance suite and automatically inferring supported features from Mesh.Status #4097

k8s-ci-robot merged 6 commits into from
Sep 20, 2025
+167 −16

Conversation

@bexxmodd
Copy link
Contributor

@bexxmodd bexxmodd commented Sep 17, 2025

What type of PR is this?
/kind feature
/area conformance-test

What this PR does / why we need it:

  1. Added flag to run conformance test for Mesh
  2. Conformance test suite will automatically read Mesh features from Mesh.Status.

Which issue(s) this PR fixes:
Fixes #3984

Does this PR introduce a user-facing change?:

Users can specify `--mesh` flag to run conformance test for mesh features and suite will infer features from Mesh.Status.SupportedFeatures field.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2025

Hi @bexxmodd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bexxmodd
Copy link
Contributor Author

bexxmodd commented Sep 17, 2025

/cc @robscott

LiorLieberman
LiorLieberman reviewed Sep 18, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Thanks for identifying the need for it as well

/lgtm

will defer to @kflynn or @robscott for approve.

Note: this aims to be 1.4

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@robscott
Copy link
Member

robscott commented Sep 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@LiorLieberman
Copy link
Member

LiorLieberman commented Sep 19, 2025

/lgtm

/assign @flynn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2025
robscott
robscott approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bexxmodd!

/approve

I think this likely also belongs in v1.4.

/cc @shaneutt

@robscott robscott added this to the v1.4.0 milestone Sep 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit df8c96c into kubernetes-sigs:main Sep 20, 2025
8 checks passed
@bexxmodd bexxmodd deleted the gep-2162/mesh-features branch September 20, 2025 01:11
@robscott
Copy link
Member

robscott commented Sep 25, 2025

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Sep 25, 2025

@robscott: new pull request created: #4124

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@bexxmodd bexxmodd mentioned this pull request Oct 14, 2025
Closed
11 tasks
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@bexxmodd @tylerauerbeck
Added flag for running mesh conformance suite and automatically infer…
0826be1 
…ring supported features from Mesh.Status (kubernetes-sigs#4097)

* Read SupportedFeatures from XMesh status for conformance test.

* Defined Mesh flag for testing.

* Renamed mesh flag.

* renamed fetched mesh features set.

* suite_test formatting.

* Set mesh flag empty default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robscott robscott robscott approved these changes

@kflynn kflynn Awaiting requested review from kflynn

@shaneutt shaneutt Awaiting requested review from shaneutt

+1 more reviewer

@LiorLieberman LiorLieberman LiorLieberman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

When Mesh Resource for populating Supported Features becomes available, update Conformance Suite.

5 participants

@bexxmodd @k8s-ci-robot @robscott @LiorLieberman @k8s-infra-cherrypick-robot