Add allowOrigins configuration to CORSAllowCredentialsBehavior and perform cleanup #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
Member
Author
Member
Author
|
@shaneutt I think this should be backported to the v1.4 release branch |
snorwin
force-pushed
the
fix-cors-test
branch
from
0675ddc to
23a1d7d
Compare
…rform cleanup Signed-off-by: Norwin Schnyder <[email protected]>
snorwin
force-pushed
the
fix-cors-test
branch
from
23a1d7d to
2228410
Compare
shaneutt
approved these changes
Sep 16, 2025
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
removed
the
do-not-merge/hold
Member
|
Thanks @snorwin! /lgtm |
k8s-ci-robot
added
the
lgtm
shaneutt
pushed a commit
that referenced
this pull request
Sep 17, 2025
…rform cleanup (#4094) Signed-off-by: Norwin Schnyder <[email protected]>
tylerauerbeck
pushed a commit
to tylerauerbeck/gateway-api
that referenced
this pull request
Nov 27, 2025
…rform cleanup (kubernetes-sigs#4094) Signed-off-by: Norwin Schnyder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/area conformance-test
What this PR does / why we need it:
Without any
allowOriginsconfigured, it’s unlikely that any implementation would be able to pass theCORSAllowCredentialsBehaviortest. In addition, I added a more meaningful description and updated the test name and files to match the naming conventions used by other HTTPRouteFilter tests.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: