Skip to content

fix: fix validation and wording when making gateway spec addresses value optional #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 16, 2025
Merged

fix: fix validation and wording when making gateway spec addresses value optional #4084

k8s-ci-robot merged 1 commit into from
Sep 16, 2025

Conversation

@bjee19
Copy link
Contributor

@bjee19 bjee19 commented Sep 13, 2025 •
edited by shaneutt
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
When Gateway.Spec.Addresses.Value became optional in this PR, CEL validation was not updated, meaning you can't create a gateway with an addresses entry with a unspecified value. Also fixed up some wording in related areas.

Which issue(s) this PR fixes:
Fixes an issue introduced in #3612

Does this PR introduce a user-facing change?:

Multiple addresses can now be requested in gateway.spec.addresses with only a type, and not a value. This was already the case for domain-prefixed address types, it now covers IPAddress and Hostname types.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 13, 2025

Hi @bjee19. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bjee19
Copy link
Contributor Author

bjee19 commented Sep 13, 2025

Manually tested ability to create a gateway with optional value field for both IPAddress and Hostname.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 16, 2025
@robscott
Copy link
Member

robscott commented Sep 16, 2025

Thanks @bjee19!

Will defer to @shaneutt on if this should be part of v1.4:
/cc @shaneutt

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bjee19, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@shaneutt shaneutt self-assigned this Sep 16, 2025
@shaneutt shaneutt moved this to Review in Release v1.4.0 Sep 16, 2025
@shaneutt
Copy link
Member

shaneutt commented Sep 16, 2025

Thanks for the catch @bjee19 🖖

Will defer to @shaneutt on if this should be part of v1.4: /cc @shaneutt

Given that we haven't cut our first RC yet, and this is about making good on a change we had intended to introduce in v1.3.0, I'm inclined to add it to v1.4.0 and get the fix out there in time for the first RC and testing.

/milestone v1.4.0

@shaneutt shaneutt added this to the v1.4.0 milestone Sep 16, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Sep 16, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6ef0152 into kubernetes-sigs:main Sep 16, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Release v1.4.0 Sep 16, 2025
shaneutt pushed a commit that referenced this pull request Sep 17, 2025
@bjee19 @shaneutt
Fix CEL validation on gateway spec addresses (#4084)
6bc7c6a
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@bjee19 @tylerauerbeck
Fix CEL validation on gateway spec addresses (kubernetes-sigs#4084)
9c41d6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kflynn kflynn Awaiting requested review from kflynn

@youngnick youngnick Awaiting requested review from youngnick

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@robscott robscott

@shaneutt shaneutt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Release v1.4.0
Status: Done

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bjee19 @k8s-ci-robot @robscott @shaneutt