Skip to content

Conversation

@snorwin
Copy link
Member

@snorwin snorwin commented Aug 29, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:
During the discussions in #4043 we realized that the conflict-resolution rules for BackendTLSPolicy were missing in the API specification. To make this clearer for both implementers and users, this PR adds the conflict-resolution rules to the TargetRef description.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2025
@snorwin
Copy link
Member Author

snorwin commented Aug 29, 2025

/cc @rikatz @kl52752

/cc @kubernetes-sigs/gateway-api-admins

@k8s-ci-robot k8s-ci-robot requested review from a team, kl52752 and rikatz August 29, 2025 21:14
@snorwin snorwin force-pushed the btlsp-target-ref-api branch from a103fd2 to 456df51 Compare August 30, 2025 06:49
@youngnick
Copy link
Contributor

Those rules LGTM, so I'll approve here, and leave the LGTM for someone else.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
Copy link
Contributor

@kl52752 kl52752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kl52752, snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kl52752
Copy link
Contributor

kl52752 commented Sep 1, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit f04abec into kubernetes-sigs:main Sep 1, 2025
19 checks passed
@shaneutt shaneutt added this to the v1.4.0 milestone Sep 2, 2025
@shaneutt shaneutt moved this to Done in Release v1.4.0 Sep 2, 2025
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants