Skip to content

TLSRoute: Require hostnames via +required #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Jul 15, 2025
Merged

TLSRoute: Require hostnames via +required #3918

k8s-ci-robot merged 2 commits into from
Jul 15, 2025

Conversation

@rostislavbobo
Copy link
Member

@rostislavbobo rostislavbobo commented Jul 15, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR makes the hostnames field required, as an addition to #3872.

Which issue(s) this PR fixes:

Fixes #3871

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2025

Hi @rostislavbobo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2025
@rostislavbobo rostislavbobo mentioned this pull request Jul 15, 2025
Merged
@rikatz
Copy link
Member

rikatz commented Jul 15, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2025
@rikatz
Copy link
Member

rikatz commented Jul 15, 2025 •
edited
Loading

/lgtm

@rostislavbobo please just fix the PR description to contain the proper entry as of:

NONE

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
JoelSpeed
JoelSpeed reviewed Jul 15, 2025
View reviewed changes
shaneutt
shaneutt requested changes Jul 15, 2025
View reviewed changes
@shaneutt shaneutt self-assigned this Jul 15, 2025
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 15, 2025
@shaneutt shaneutt added this to the v1.4.0 milestone Jul 15, 2025
@shaneutt shaneutt moved this to Review in Release v1.4.0 Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 15, 2025
@rikatz
Copy link
Member

rikatz commented Jul 15, 2025

/lgtm cancel

Canceling lgtm due to the required changes

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@rostislavbobo rostislavbobo changed the title TLSRoute: Require hostnames, no omitempty TLSRoute: Require hostnames Jul 15, 2025
@rostislavbobo rostislavbobo changed the title TLSRoute: Require hostnames TLSRoute: Require hostnames via +require Jul 15, 2025
shaneutt
shaneutt approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rostislavbobo, @rikatz and @JoelSpeed!

/approve

@rostislavbobo
Copy link
Member Author

rostislavbobo commented Jul 15, 2025

Thanks you @JoelSpeed , @rikatz , @shaneutt for the review! Using +required instead

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rostislavbobo, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
@rostislavbobo rostislavbobo changed the title TLSRoute: Require hostnames via +require TLSRoute: Require hostnames via +required Jul 15, 2025
@rikatz
Copy link
Member

rikatz commented Jul 15, 2025

/lgtm
/hold

leaving the unhold for project maintainers :)

Thanks @rostislavbobo !!

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 15, 2025
@shaneutt shaneutt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit a07680f into kubernetes-sigs:main Jul 15, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Release v1.4.0 Jul 15, 2025
@rostislavbobo rostislavbobo deleted the tlsroute-hostnames-no-omitempty branch July 15, 2025 14:28
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@rostislavbobo @tylerauerbeck
TLSRoute: Require hostnames via +required (kubernetes-sigs#3918)
a2800cd 
* TLSRoute: Require hostnames, no omitempty

* TLSRoute: Require hostnames using +required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaneutt shaneutt shaneutt approved these changes

@mlavacca mlavacca Awaiting requested review from mlavacca

@robscott robscott Awaiting requested review from robscott

+1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shaneutt shaneutt

@rikatz rikatz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Release v1.4.0
Status: Done

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

Require hostnames for TLSRoutes

5 participants

@rostislavbobo @k8s-ci-robot @rikatz @shaneutt @JoelSpeed