Allow preprepared CoreDNS image to be used #3906

aaronjwood · 2025-07-08T18:55:41Z

What type of PR is this?
/kind bug
/area conformance-machinery

What this PR does / why we need it:
For folks that are pulling images from Docker's public registry in an unauthenticated way rate limits are an immediate problem. This PR fixes three things:

Explicitly sets the pull policy for CoreDNS to be IfNotPresent, allowing for a cluster with an already-prepared CoreDNS image to be used
Moves away from Docker's public registry to registry.k8s.io/coredns/coredns
Fixes getContentsFromPathOrURL to correctly handle multiple fs.FS. If this was already supported client code could've easily done something like this to work around the issue:

virtFS := fstest.MapFS{...} // Imagine this to hold an override for the manifest with issues.
suite.ConformanceOptions{
...
    ManifestFS:               []fs.FS{&conformance.Manifests, &virtFS},
...
}

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2025-07-08T18:55:45Z

@aaronjwood: The label(s) kind/conformance-machinery cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind bug
/kind conformance-machinery

What this PR does / why we need it:
For folks that are pulling images from Docker's public registry in an unauthenticated way rate limits are an immediate problem. This PR fixes two things:

Explicitly sets the pull policy for CoreDNS to be IfNotPresent, allowing for a cluster with an already-prepared CoreDNS image to be used

Fixes getContentsFromPathOrURL to correctly handle multiple fs.FS. If this was already supported client code could've easily done something like this to work around the issue:
virtFS := fstest.MapFS{...} // Imagine this to hold an override for the manifest with issues.
suite.ConformanceOptions{
...
   ManifestFS:               []fs.FS{&conformance.Manifests, &virtFS},
...
}
Does this PR introduce a user-facing change?:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-07-08T18:55:51Z

Welcome @aaronjwood!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-08T18:55:52Z

Hi @aaronjwood. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

aaronjwood · 2025-07-08T19:03:07Z

/area conformance-machinery

mikemorris · 2025-07-08T19:18:49Z

/ok-to-test

aaronjwood · 2025-07-08T22:42:59Z

The failing test looks like some kind of flake...? Is it known to anybody?

aaronjwood · 2025-07-09T16:31:26Z

/retest

mikemorris · 2025-07-09T16:52:06Z

I missed which test was failing, looks like everything is in good shape now.

Tagging conformance leads for review @candita @sunjayBhatia @arkodg @LiorLieberman

aaronjwood · 2025-07-17T18:00:46Z

Wanted to follow up on this and see if we can get it merged. Thanks!

rikatz · 2025-08-18T14:24:44Z

and what if using registry.k8s.io/coredns/coredns:v1.12.0 instead, and pulling directly from our own repo?

rikatz · 2025-08-18T14:25:28Z

conformance/base/manifests.yaml

      - args:
        - -conf
        - /root/Corefile
        image: coredns/coredns


we can probably also pull directly from registry.k8s.io/coredns/coredns:v1.12.0 and while the imagePullPolicy is great, we avoid any sort of rate limiting at all

I'd prefer this too, I didn't realize the image existed here. When I poked around in the past I didn't see anything that referenced CoreDNS having an image here.

I'll update the URI.

Since there's no latest in this registry are folks ok moving to pinning a specific version here? Someone/something will need to keep it moving going forward.

I am ok with keeping it pinned (tho it is good to have some second opinion), and tbh I prefer it :) IMHO latest can bring some undesired behavior and as this is used for test, we may want consistency.

Also, usually the CoreDNS version is bumped together with Kubernetes version (eg.: kubernetes/kubernetes#131151)

Sounds good, I've seen the arguments for pinning vs not pinning go both ways. I'll update this and see if we can reach a consensus.

+1 to keep it pinned so we have a point in time test manifest that can be reproducible - would hate for a new version of coredns to affect an old version of our conformance tests.

aaronjwood · 2025-09-08T19:45:10Z

Any interest in merging this?

robscott · 2025-09-08T20:07:32Z

Thanks @aaronjwood!

/lgtm
/approve

k8s-ci-robot · 2025-09-08T20:07:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaronjwood, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~conformance/OWNERS~~ [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Switch to registry.k8s.io/coredns/coredns, only pull if not present * Properly support multiple embedded manifests

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 8, 2025

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2025

k8s-ci-robot requested review from candita and mikemorris July 8, 2025 18:55

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2025

k8s-ci-robot added the area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. label Jul 8, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2025

rikatz reviewed Aug 18, 2025

View reviewed changes

aaronjwood force-pushed the support-byo-coredns-image branch from 1d9fd9d to ab44ea9 Compare August 18, 2025 22:01

aaronjwood added 2 commits August 18, 2025 15:05

Switch to registry.k8s.io/coredns/coredns, only pull if not present

7f612b9

Properly support multiple embedded manifests

d868a0d

aaronjwood force-pushed the support-byo-coredns-image branch from ab44ea9 to d868a0d Compare August 18, 2025 22:06

k8s-ci-robot assigned robscott Sep 8, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025

k8s-ci-robot merged commit 78f48a1 into kubernetes-sigs:main Sep 8, 2025
8 checks passed

shaneutt added this to Release v1.4.0 Sep 17, 2025

shaneutt moved this to Completed in Release v1.4.0 Sep 17, 2025

shaneutt moved this from Completed to Done in Release v1.4.0 Sep 17, 2025

shaneutt added this to the v1.4.0 milestone Sep 17, 2025

shaneutt pushed a commit that referenced this pull request Sep 17, 2025

Allow preprepared CoreDNS image to be used (#3906)

d57b9d6

* Switch to registry.k8s.io/coredns/coredns, only pull if not present * Properly support multiple embedded manifests

Allow preprepared CoreDNS image to be used #3906

Allow preprepared CoreDNS image to be used #3906

Uh oh!

Conversation

aaronjwood commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 8, 2025

Uh oh!

k8s-ci-robot commented Jul 8, 2025

Uh oh!

k8s-ci-robot commented Jul 8, 2025

Uh oh!

aaronjwood commented Jul 8, 2025

Uh oh!

mikemorris commented Jul 8, 2025

Uh oh!

aaronjwood commented Jul 8, 2025

Uh oh!

aaronjwood commented Jul 9, 2025

Uh oh!

mikemorris commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronjwood commented Jul 17, 2025

Uh oh!

rikatz commented Aug 18, 2025

Uh oh!

rikatz Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

aaronjwood Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

aaronjwood Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

rikatz Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronjwood Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

robscott Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

aaronjwood commented Sep 8, 2025

Uh oh!

robscott commented Sep 8, 2025

Uh oh!

k8s-ci-robot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aaronjwood commented Jul 8, 2025 •

edited

Loading

mikemorris commented Jul 9, 2025 •

edited

Loading

rikatz Aug 18, 2025 •

edited

Loading