Skip to content

Improve distribution tests in conformance for HTTPRouteWeight #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Aug 11, 2025
Merged

Improve distribution tests in conformance for HTTPRouteWeight #3880

k8s-ci-robot merged 1 commit into from
Aug 11, 2025

Conversation

@carsontham
Copy link
Contributor

@carsontham carsontham commented Jun 24, 2025

What type of PR is this?

/area conformance-test

What this PR does / why we need it:
Adding entropy to distribution tests for HTTPRouteWeight as per comment #3855 (review)

This is done by reusing the entropy method to create jitter in the requests.

Which issue(s) this PR fixes:

Fixes #3832

Does this PR introduce a user-facing change?:

Improve conformance distribution tests for HTTPRouteWeight

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 24, 2025

Hi @carsontham. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@carsontham
Copy link
Contributor Author

carsontham commented Jun 24, 2025 •
edited
Loading

hey @LiorLieberman! created a follow-up PR for HTTPRouteWeight as per discussed previously. Please take a look, thanks!

@mikemorris
Copy link
Contributor

mikemorris commented Jun 24, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
@LiorLieberman
Copy link
Member

LiorLieberman commented Aug 6, 2025

@carsontham sorry! just now seeing it.

Can you rebase?

@carsontham carsontham force-pushed the add-entropy-to-httproute-weight branch from 1360aaa to efd17ca Compare August 10, 2025 10:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
@carsontham
Copy link
Contributor Author

carsontham commented Aug 10, 2025

hey @LiorLieberman, I have rebased it, could you take a look, thanks!

@LiorLieberman
Copy link
Member

LiorLieberman commented Aug 11, 2025

/cc

LiorLieberman
LiorLieberman reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carsontham

looks good to me!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carsontham, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 372a5b0 into kubernetes-sigs:main Aug 11, 2025
8 checks passed
sayboras added a commit to cilium/cilium that referenced this pull request Aug 12, 2025
@sayboras
vendor: Bump gateway-api to the latest
a154ddf 
This is to mainly pick up the below upstream changes

Relates: kubernetes-sigs/gateway-api#3880
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Aug 12, 2025
Closed
sayboras added a commit to cilium/cilium that referenced this pull request Aug 12, 2025
@sayboras
vendor: Bump gateway-api to the latest
ff1e493 
This is to mainly pick up the below upstream changes

Relates: kubernetes-sigs/gateway-api#3880
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Aug 12, 2025
@sayboras
vendor: Bump gateway-api to the latest
e8dfa24 
This is to mainly pick up the below upstream changes

Relates: kubernetes-sigs/gateway-api#3880
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Aug 27, 2025
@sayboras
vendor: Bump gateway-api to the latest
a96d49a 
This is to mainly pick up the below upstream changes

Relates: kubernetes-sigs/gateway-api#3880
Signed-off-by: Tam Mach <[email protected]>
@ciarams87 ciarams87 mentioned this pull request Aug 27, 2025
Closed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
@carsontham @tylerauerbeck
added entropy to HTTPRoute-weight (kubernetes-sigs#3880)
7621062 
Signed-off-by: carsontham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikemorris mikemorris Awaiting requested review from mikemorris

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

1 more reviewer

@LiorLieberman LiorLieberman LiorLieberman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improving distribution tests in conformance

4 participants

@carsontham @k8s-ci-robot @mikemorris @LiorLieberman