-
Notifications
You must be signed in to change notification settings - Fork 632
fix meshredirectport and schemeredirect mesh conformance features #3847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @kflynn |
|
Thanks @LiorLieberman! /approve Wonder if I can even do that. 🙂 |
Need both lgtm and approve |
|
🙄 /lgtm |
shaneutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, LiorLieberman, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bernetes-sigs#3847) * include meshredirectport in extended * Update mesh.go
/kind bug
/area conformance-machinery
What this PR does / why we need it:
include missing feature in extended mesh tests suite and fixing a typo
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: