Skip to content

Conversation

@LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Jun 10, 2025

/kind bug
/area conformance-machinery

What this PR does / why we need it:
include missing feature in extended mesh tests suite and fixing a typo

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@LiorLieberman
Copy link
Member Author

/cc @kflynn

@k8s-ci-robot k8s-ci-robot requested a review from kflynn June 10, 2025 03:42
@LiorLieberman LiorLieberman changed the title include meshredirectport in extended fix meshredirectport and schemeredirect mesh conformance features Jun 10, 2025
@kflynn
Copy link
Contributor

kflynn commented Jun 10, 2025

Thanks @LiorLieberman!

/approve

Wonder if I can even do that. 🙂

@LiorLieberman
Copy link
Member Author

Thanks @LiorLieberman!

/approve

Wonder if I can even do that. 🙂

Need both lgtm and approve

@kflynn
Copy link
Contributor

kflynn commented Jun 10, 2025

🙄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, LiorLieberman, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 17a60f6 into kubernetes-sigs:main Jun 11, 2025
13 checks passed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants