Skip to content

Conversation

@LiorLieberman
Copy link
Member

What type of PR is this?
/area conformance-test

Add mesh tests for request header modifier
This is a follow up to #3729

What this PR does / why we need it:
Add mesh tests coverage

Which issue(s) this PR fixes:

Related #3581

Does this PR introduce a user-facing change?:

Add mesh conformance for httproute-queryparmas-match

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2025
@kflynn
Copy link
Contributor

kflynn commented Jun 5, 2025

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@kflynn
Copy link
Contributor

kflynn commented Jun 9, 2025

/lgtm

@LiorLieberman
Copy link
Member Author

Approval is whats missing :)

@robscott
Copy link
Member

robscott commented Jun 9, 2025

Thanks @LiorLieberman!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@kflynn
Copy link
Contributor

kflynn commented Jun 9, 2025

😂 🤦‍♂️ 🙂

@k8s-ci-robot k8s-ci-robot merged commit 962d22f into kubernetes-sigs:main Jun 9, 2025
13 checks passed
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants