Requiring Port number on ListenerSet Listener #3753
Merged
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We missed this when reviewing the ListenerSet GEP. Although an optional port that would require implementations to assign a port could be legitimately useful, I think we haven't fully processed this concept. Moving this back to required allows us to make it optional in the future, where starting with optional would make it much more painful to transition to required.
Some potential concerns of an optional port on ListenerSet:
With all that said, I think this is potentially a very useful idea, I just don't think we spent enough time on this while reviewing ListenerSet and would prefer to take the safest possible path forward towards RC2. This is not "never", just "not yet".
Does this PR introduce a user-facing change?:
/cc @dprotaso @youngnick