feat(conformance): validate implementation flags #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Member
Author
|
/retest |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/retest |
mlavacca
force-pushed
the
validate-conf-suite-flags
branch
from
0f34cff to
d6a4019
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
@youngnick I lost your lgtm as I needed to lint the code. Do you mind taking another look? |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
validate-conf-suite-flags
branch
from
d6a4019 to
f07b535
Compare
k8s-ci-robot
removed
the
needs-rebase
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
Bit odd to have a function called |
LiorLieberman
added a commit
to LiorLieberman/gateway-api
that referenced
this pull request
Jul 15, 2025
…sigs#3715)" This reverts commit 564720a.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 15, 2025
tylerauerbeck
pushed a commit
to tylerauerbeck/gateway-api
that referenced
this pull request
Nov 27, 2025
* feat(conformance): validate implementation flags Signed-off-by: Mattia Lavacca <[email protected]> * chore: gofumpt Signed-off-by: Mattia Lavacca <[email protected]> --------- Signed-off-by: Mattia Lavacca <[email protected]>
tylerauerbeck
pushed a commit
to tylerauerbeck/gateway-api
that referenced
this pull request
Nov 27, 2025
…sigs#3715)" (kubernetes-sigs#3920) This reverts commit 564720a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area conformance-machinery
What this PR does / why we need it:
The conformance suite implementation-related flags are properly validated.
Which issue(s) this PR fixes:
Fixes #2178
Does this PR introduce a user-facing change?: