Remove NUMA node boundary for ResourceSlice splitting#55
Remove NUMA node boundary for ResourceSlice splitting#55k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pravk03 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pravk03: GitHub didn't allow me to request PR reviews from the following users: catblade. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @ffromani |
ffromani
left a comment
There was a problem hiding this comment.
LGTM with one possible improvement, please see the inline comment
Removes the self-imposed restriction of confining each ResourceSlice to a single NUMA node when we exceed the 128 device limit. Slices will now be created by simply chunking the devices, potentially spanning NUMA nodes.
4c7d151 to
837aed2
Compare
Remove NUMA node boundary for ResourceSlice splitting
Removes the self-imposed restriction of confining each
ResourceSliceto a single NUMA node when we exceed the 128 device limit (set here). Slices will now be created by simply chunking the devices, potentially spanning NUMA nodes.Fixes: #5