feat(critest): Add image manager consistency and idempotency tests#1959
Merged
Merged
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/L
SergeyKanzhelev
force-pushed
the
imageTests
branch
2 times, most recently
from
December 12, 2025 22:29
1f29cec to
c042889
Compare
SergeyKanzhelev
commented
Dec 12, 2025
Member
|
@SergeyKanzhelev do you mind a rebase? |
SergeyKanzhelev
force-pushed
the
imageTests
branch
3 times, most recently
from
January 14, 2026 21:32
e0f104f to
3d68d48
Compare
saschagrunert
force-pushed
the
imageTests
branch
from
January 15, 2026 12:47
7b0382e to
3d68d48
Compare
bitoku
reviewed
Jan 27, 2026
SergeyKanzhelev
force-pushed
the
imageTests
branch
3 times, most recently
from
February 5, 2026 23:45
f618fec to
9ce9666
Compare
Member
Author
|
Failures seems not related to this PR. |
Member
Author
|
@saschagrunert can you please try rerun tests? Failures seem unrelated. If passing - this is OK to merge |
SergeyKanzhelev
force-pushed
the
imageTests
branch
from
February 11, 2026 02:35
9ce9666 to
c04bc90
Compare
Member
|
Tests are green now, that one containerd test flakes all the time on windows. |
Member
Author
@saschagrunert are you ok to merge this? |
Member
|
@SergeyKanzhelev yes, but please rebase it once again |
k8s-ci-robot
added
the
needs-rebase
SergeyKanzhelev
force-pushed
the
imageTests
branch
from
February 26, 2026 16:57
c04bc90 to
4c31119
Compare
k8s-ci-robot
removed
the
needs-rebase
Member
Author
|
rebased, waiting for tests |
Adds a new test suite in to validate the idempotency and immediate consistency of CRI image operations. This suite includes tests to ensure: - An image is available in ListImages and ImageStatus immediately after being pulled. - An image is absent from ListImages and ImageStatus immediately after being removed. - Concurrent RemoveImage calls for the same image are handled gracefully without errors, and the image is confirmed to be removed immediately after each call returns. Additionally, this commit enhances the existing Image Manager test suite in with tests for removing images that have multiple tags, including tags that point to the same image digest from different registry domains (e.g., registry.k8s.io and its k8s.gcr.io mirror). The tests are written to be resilient to other images pre-existing on the test environment.
SergeyKanzhelev
force-pushed
the
imageTests
branch
from
February 26, 2026 19:32
4c31119 to
b164902
Compare
SergeyKanzhelev
commented
Feb 26, 2026
|
|
||
| var defaultRuntimeEndpoints = []string{"npipe:////./pipe/containerd-containerd", "npipe:////./pipe/cri-dockerd"} | ||
| var defaultConfigPath string | ||
| var ( |
Member
Author
There was a problem hiding this comment.
this was done by golangci-lint fmt. Not sure why formatter is not aligned with run --fix, but included it here so it will not complain any longer
saschagrunert
approved these changes
Feb 27, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new test suite in to validate the idempotency and immediate consistency of CRI image operations.
This suite includes tests to ensure:
Additionally, this commit enhances the existing Image Manager test suite in with tests for removing images that have multiple tags, including tags that point to the same image digest from different registry domains (e.g., registry.k8s.io and its k8s.gcr.io mirror). The tests are written to be resilient to other images pre-existing on the test environment.
/kind feature
This code was generated by Gemini
Special notes for your reviewer:
Follow up from #1911
Does this PR introduce a user-facing change?