Update Windows test image to use ltsc2022 base#1952
Conversation
k8s-ci-robot
added
kind/failing-test
k8s-ci-robot
added
approved
bab58f5 to
b79023c
Compare
k8s-ci-robot
added
size/S
b79023c to
1e1533e
Compare
k8s-ci-robot
added
size/M
1e1533e to
1de6100
Compare
Update the Windows test image Dockerfile to use the ltsc2022 (Windows Server 2022) base image instead of 1809 (Windows Server 2019) to support newer Windows platforms and resolve compatibility issues with containerd CI. Fix e2e test cleanup to properly remove all image references in CRI-O. Multi-arch images create multiple digest references that remain after removing by tag. The AfterEach cleanup in pull_test, inspect_test, and inspecti_test now properly handles multi-line image IDs by splitting and joining them to avoid invalid reference format errors. Signed-off-by: Sascha Grunert <[email protected]>
1de6100 to
9900d2a
Compare
|
@fuweid: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM
nit.. could use a func for removing the image and any digest references
alternative nit.. could add an option to the rmi command..
|
@mikebrow: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, mikebrow, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kindly ping @haircommander @klueska |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
5 participants
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Update the Windows test image Dockerfile to use the ltsc2022 (Windows Server 2022) base image instead of 1809 (Windows Server 2019) to support newer Windows platforms and resolve compatibility issues with containerd CI.
Which issue(s) this PR fixes:
Fixes #1950
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?