Fix --image filter for crictl inspect and exec#1752
Merged
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
inspect-image
branch
from
January 21, 2025 09:01
48e7fdd to
1253765
Compare
saschagrunert
changed the title
--image filter for crictl inspect and exec--image filter for crictl inspect and exec
k8s-ci-robot
added
the
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
inspect-image
branch
from
January 21, 2025 09:43
1253765 to
c151b5a
Compare
k8s-ci-robot
added
size/L
saschagrunert
changed the title
--image filter for crictl inspect and exec--image filter for crictl inspect and exec
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
inspect-image
branch
from
January 21, 2025 09:46
c151b5a to
a6bea79
Compare
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
Member
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the
--imagefilter for supported subcommands.Which issue(s) this PR fixes:
Fixes #1750
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?