feat: retrieve specific log stream of a container#1724
Merged
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
Member
Author
knight42
force-pushed
the
feat/log-stream
branch
from
December 14, 2024 15:38
6f2b8be to
efe2ec7
Compare
Member
|
@knight42 could you fix the lint errors? |
Signed-off-by: Jian Zeng <[email protected]>
knight42
force-pushed
the
feat/log-stream
branch
from
December 25, 2024 03:38
123dbbd to
7d81898
Compare
Member
Author
Sure! Please take another look. |
Member
Author
|
@feiskyer The test failure appears to be irrelevant. Could you please rerun the test? It seems I am unable to do so on my end. |
feiskyer
approved these changes
Dec 30, 2024
feiskyer
left a comment
feiskyer
left a comment
Member
There was a problem hiding this comment.
Thanks addressing the lint issues
Rerun works now
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, knight42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Per kubernetes/kubernetes#127360 (comment), I am going to make crictl be able to fetch a specific log stream of a container.
BTW it turns out that crictl reads the log file directly (without any communication with apiserver or kubelet), so this change actually doesn't depend on k8s 1.32 APIs.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?