Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.0
Choose a base ref
...
head repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.1
Choose a head ref
  • 8 commits
  • 7 files changed
  • 4 contributors

Commits on Jan 6, 2025

  1. chore: regenerate testdata using go generate

    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    7a92e7b View commit details
    Browse the repository at this point in the history
  2. pkg/crd: fix alias type parsing

    Using Underlying() was working for basic types but was resolving "too
    far" for more complex type, as for the structure. I.e. instead of
    retrieving the new type for aliased, it actually retrieved the
    underyling (who could have guessed) actual type.
    
    For example, for a string alias, we have:
    - Alias type info:           testdata.kubebuilder.io/cronjob.StringAlias
    - Rhs from the alias def:    string
    - Underlying from the alias: string
    
    But for a struct alias, we have:
    - Alias type info:           testdata.kubebuilder.io/cronjob.InlineAlias
    - Rhs from the alias def:    testdata.kubebuilder.io/cronjob.EmbeddedStruct
    - Underlying from the alias: struct{FromEmbedded string "json:\"fromEmbedded,omitempty\""}
    
    I also imagine that we don't handle nested alias, but this is for
    another patch.
    
    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    a7ed777 View commit details
    Browse the repository at this point in the history
  3. pkg/crd: add a test for embedded/inline struct type alias

    User tsaarni bumped into a panic when using embedded/inline field with a
    type alias and that Alias types are enabled in Go. They thankfully
    included a reproducer that is shipped in this patch from the issue
    #1088.
    
    Co-authored-by: Tero Saarni <[email protected]>
    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy and tsaarni committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    cf0446d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2025

  1. Merge pull request #1122 from mtardy/pr/mtardy/embedded-alias

    🐛 pkg/crd: fix alias type parsing for struct type alias
    k8s-ci-robot authored Jan 10, 2025
    Configuration menu
    Copy the full SHA
    9814fc3 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2025

  1. 🌱 Bump golang.org/x/tools

    Bumps the all-go-mod-patch-and-minor group with 1 update: [golang.org/x/tools](https://github.com/golang/tools).
    
    
    Updates `golang.org/x/tools` from 0.28.0 to 0.29.0
    - [Release notes](https://github.com/golang/tools/releases)
    - [Commits](golang/tools@v0.28.0...v0.29.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/tools
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: all-go-mod-patch-and-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    4489afe View commit details
    Browse the repository at this point in the history
  2. 🌱 Bump the all-github-actions group across 1 directory with 3 updates

    Bumps the all-github-actions group with 3 updates in the / directory: [softprops/action-gh-release](https://github.com/softprops/action-gh-release), [tj-actions/changed-files](https://github.com/tj-actions/changed-files) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request).
    
    
    Updates `softprops/action-gh-release` from 2.1.0 to 2.2.1
    - [Release notes](https://github.com/softprops/action-gh-release/releases)
    - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
    - [Commits](softprops/action-gh-release@01570a1...c95fe14)
    
    Updates `tj-actions/changed-files` from 45.0.5 to 45.0.6
    - [Release notes](https://github.com/tj-actions/changed-files/releases)
    - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
    - [Commits](tj-actions/changed-files@bab30c2...d6e91a2)
    
    Updates `peter-evans/create-pull-request` from 7.0.5 to 7.0.6
    - [Release notes](https://github.com/peter-evans/create-pull-request/releases)
    - [Commits](peter-evans/create-pull-request@5e91468...67ccf78)
    
    ---
    updated-dependencies:
    - dependency-name: softprops/action-gh-release
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: all-github-actions
    - dependency-name: tj-actions/changed-files
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-github-actions
    - dependency-name: peter-evans/create-pull-request
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-github-actions
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    00cc28b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1125 from kubernetes-sigs/dependabot/github_actio…

    …ns/all-github-actions-ccf1fcee45
    
    🌱 Bump the all-github-actions group across 1 directory with 3 updates
    k8s-ci-robot authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    862d84c View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1124 from kubernetes-sigs/dependabot/go_modules/a…

    …ll-go-mod-patch-and-minor-a7e3f36068
    
    🌱 Bump golang.org/x/tools from 0.28.0 to 0.29.0 in the all-go-mod-patch-and-minor group
    k8s-ci-robot authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    34a0f8e View commit details
    Browse the repository at this point in the history
Loading