Skip to content

🐛 Fix ginkgo panic in webhook integration test#3288

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sbueringer:pr-fix-panic-webhook
Aug 18, 2025
Merged

🐛 Fix ginkgo panic in webhook integration test#3288
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sbueringer:pr-fix-panic-webhook

Conversation

@sbueringer
Copy link
Copy Markdown
Member

@sbueringer sbueringer commented Aug 18, 2025

Signed-off-by: Stefan Büringer [email protected]

Fixes https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-controller-runtime-test/1956593964882595840

Expect(err).NotTo(HaveOccurred())
	/home/prow/go/src/github.com/kubernetes-sigs/controller-runtime/pkg/webhook/webhook_integration_test.go:115
	  When you, or your assertion library, calls Ginkgo's Fail(),
	  Ginkgo panics to prevent subsequent assertions from running.
	
	  Normally Ginkgo rescues this panic so you shouldn't see it.

@sbueringer
Copy link
Copy Markdown
Member Author

sbueringer commented Aug 18, 2025

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 18, 2025

LGTM label has been added.

DetailsGit tree hash: e283f594938d7fc2d913dbef1179b170470fb270

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8deb602 into kubernetes-sigs:main Aug 18, 2025
11 checks passed
@sbueringer sbueringer deleted the pr-fix-panic-webhook branch August 18, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @alvaroaleman