⚠️ Migration to the new events API by clebs · Pull Request #3262 · kubernetes-sigs/controller-runtime

clebs · 2025-07-22T20:32:25Z

This Pull Request migrates from the old events API (k8s.io/client-go/tools/record) to the new API (k8s.io/client-go/tools/events).

Closes #2141

k8s-ci-robot · 2025-07-22T20:32:35Z

Hi @clebs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

clebs · 2025-07-22T20:36:47Z

Open Items:

StartRecordingToSink: manage the context/channel in the provider on ensureRecording and Stop.
StartWatcher: see if this is still needed and how to adapt it if it is.
Leader election: resourcelock.ResourceLockConfig is still using the old API.
This has now been solved by adding an adapter that turns old API calls into new API calls (albeit pretty simplistic). So that way on the backend we have only the new API and places that require the old can use the adapter.
Update unit tests.

alvaroaleman · 2025-07-22T20:50:59Z

/ok-to-test

alvaroaleman

two questions

pkg/recorder/recorder.go

pkg/internal/recorder/recorder.go

sbueringer · 2025-08-07T16:39:10Z

/assign

pkg/internal/recorder/recorder.go

pkg/leaderelection/leader_election.go

pkg/manager/manager.go

pkg/recorder/recorder.go

sbueringer · 2025-08-12T12:23:53Z

@clebs Just a heads up. If we want to get this into the next CR minor release the deadline is in 2-3 weeks. We want to release the next CR minor shortly after the Kubernetes minor which is scheduled for 27th August

k8s-ci-robot · 2025-10-14T07:58:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, clebs, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Motivated by kubernetes-sigs/controller-runtime#3262

…`v0.23.1`, `sigs.k8s.io/controller-tools` to `v0.20.0` (#13982) * `make tidy && make generate` * Solve `OpenTelemetry-Operator` dependency issue The `OpenTelemetry-Operator` includes dependencies to an older version of `sigs.k8s.io/controller-runtime` which is incompatible with the version (v0.23) used in Gardener. Copying the API packages solves the dependency conflict for now. See open-telemetry/opentelemetry-operator#4667 for more information. * Adapt to incompatible changes * Adapt `OpenAPI` generation The generation needs to be adapted due to kubernetes/kube-openapi#563 * Migrate to `k8s.io/client-go/tools/events` Motivated by kubernetes-sigs/controller-runtime#3262 * Refactor: Remove obsolete `rest.Config` constructor * Add `ReconciliationTimeout` panel Add `ReconciliationTimeout` panel to the controller details dashboard. The uses the newly introduced `controller_runtime_reconcile_timeouts_total metric` metric (see kubernetes-sigs/controller-runtime#3382). * Change `NodeAgentAuthorizer` integration test Don't use the event recorder to test patch permissions. We've seen cases where the event recorder drops events if they are recorded too quickly.

Upgrades controller-runtime from v0.22.4 to v0.23.3. The k8s.io/* packages were already at v0.35.0 and required no changes. The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.

The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025

k8s-ci-robot requested review from JoelSpeed and sbueringer July 22, 2025 20:32

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2025

clebs changed the title ~~⚠ Migration to the new events API~~ ⚠️ Migration to the new events API Jul 22, 2025

clebs mentioned this pull request Jul 22, 2025

Switch to use events.EventRecorder instead of record.EventRecorder #2141

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2025

clebs force-pushed the new-events-api branch from 732ed05 to c8698d8 Compare July 23, 2025 15:49

alvaroaleman reviewed Jul 23, 2025

View reviewed changes

pkg/recorder/recorder.go Show resolved Hide resolved

pkg/recorder/recorder.go Outdated Show resolved Hide resolved

clebs force-pushed the new-events-api branch 2 times, most recently from 6bfbd83 to 0528c33 Compare July 24, 2025 12:54

valdar reviewed Jul 25, 2025

View reviewed changes

pkg/internal/recorder/recorder.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025

clebs force-pushed the new-events-api branch from 592ade2 to 4541c71 Compare July 30, 2025 14:02

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2025

clebs marked this pull request as ready for review August 7, 2025 09:26

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2025

k8s-ci-robot requested review from alvaroaleman and troy0820 August 7, 2025 09:26

clebs force-pushed the new-events-api branch from b1e2d6c to bc36d51 Compare August 7, 2025 09:31

k8s-ci-robot assigned sbueringer Aug 7, 2025

sbueringer reviewed Aug 12, 2025

View reviewed changes

sbueringer removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 14, 2025

k8s-ci-robot merged commit 2ebd17f into kubernetes-sigs:main Oct 14, 2025
10 of 11 checks passed

clebs deleted the new-events-api branch October 14, 2025 08:10

This was referenced Jan 20, 2026

fix(deps): update module sigs.k8s.io/controller-runtime to v0.23.0 elastic/cloud-on-k8s#9054

Merged

Migrate from deprecated record.EventRecorder to events.EventRecorder (events.k8s.io/v1) elastic/cloud-on-k8s#9056

Closed

This was referenced Jan 21, 2026

REQUEST: New membership for clebs kubernetes/org#6076

Closed

REQUEST: New membership for clebs kubernetes/org#6077

Closed

weisdd mentioned this pull request Jan 23, 2026

fix(deps): update module sigs.k8s.io/controller-runtime to v0.23.0 grafana/grafana-operator#2459

Merged

1 task

This was referenced Jan 26, 2026

chore(deps): upgrade Kubernetes dependencies to v0.35.0 and migrate to generic webhook APIs kubernetes-sigs/lws#741

Merged

Migrate to new events API and replace deprecated EventRecorder methods kubernetes-sigs/lws#742

Closed

andreyvelich mentioned this pull request Jan 26, 2026

chore(deps): Bump Go 1.25, k8s v1.35, and controller-runtime v0.23.1 kubeflow/trainer#3127

Merged

timuthy mentioned this pull request Jan 27, 2026

Upgrade k8s.io/* to v0.35, sigs.k8s.io/controller-runtime to v0.23 gardener/gardener#13901

Closed

jmclong mentioned this pull request Jan 28, 2026

Migrate to GetEventRecorderFor for controller-runtime v0.23.0 and later Azure/local-csi-driver#345

Closed

Copilot AI mentioned this pull request Jan 28, 2026

refactor: update events API to use GetEventRecorder method for controller-runtime event code Azure/local-csi-driver#346

Merged

4 tasks

bjosv mentioned this pull request Jan 30, 2026

Migrate from deprecated record.EventRecorder to events.EventRecorder valkey-io/valkey-operator#70

Closed

timuthy added a commit to timuthy/gardener that referenced this pull request Feb 4, 2026

Migrate to k8s.io/client-go/tools/events

3906717

Motivated by kubernetes-sigs/controller-runtime#3262

timuthy added a commit to timuthy/gardener that referenced this pull request Feb 6, 2026

Migrate to k8s.io/client-go/tools/events

5906a34

Motivated by kubernetes-sigs/controller-runtime#3262

timuthy added a commit to timuthy/gardener that referenced this pull request Feb 6, 2026

Migrate to k8s.io/client-go/tools/events

1ca3a08

Motivated by kubernetes-sigs/controller-runtime#3262

This was referenced Feb 9, 2026

[Umbrella] Bump Kubernetes dependency from v1.34 to v1.35 karmada-io/karmada#7140

Open

Bump [email protected] karmada-io/karmada#7182

Merged

timuthy added a commit to timuthy/gardener that referenced this pull request Feb 11, 2026

Migrate to k8s.io/client-go/tools/events

1af137c

Motivated by kubernetes-sigs/controller-runtime#3262

adinilfeld mentioned this pull request Feb 25, 2026

Migrate to new events API kubernetes-sigs/lws#761

Merged

XiShanYongYe-Chang mentioned this pull request Mar 4, 2026

[Analyse] Migrate event recorder from GetEventRecorderFor to GetEventRecorder karmada-io/karmada#7251

Open

3 tasks

Tomasz-Smelcerz-SAP mentioned this pull request Mar 4, 2026

chore: Bump ocm.software/ocm from v0.35.0 to v0.36.0; bump controller-runtime from v0.22.4 to v0.23.0 kyma-project/lifecycle-manager#3099

Merged

felix-kaestner mentioned this pull request Mar 27, 2026

Upgrade sigs.k8s.io/controller-runtime to v0.23.3 ironcore-dev/network-operator#264

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ Migration to the new events API#3262

⚠️ Migration to the new events API#3262
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
clebs:new-events-api

clebs commented Jul 22, 2025

Uh oh!

k8s-ci-robot commented Jul 22, 2025

Uh oh!

clebs commented Jul 22, 2025 •

edited

Loading

Uh oh!

alvaroaleman commented Jul 22, 2025

Uh oh!

alvaroaleman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbueringer commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbueringer commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Oct 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

clebs commented Jul 22, 2025

Uh oh!

k8s-ci-robot commented Jul 22, 2025

Uh oh!

clebs commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alvaroaleman commented Jul 22, 2025

Uh oh!

alvaroaleman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbueringer commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbueringer commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Oct 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

clebs commented Jul 22, 2025 •

edited

Loading