Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.16.0
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.16.1
Choose a head ref
  • 5 commits
  • 6 files changed
  • 3 contributors

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    736a76b View commit details
    Browse the repository at this point in the history
  2. Update generated code

    dependabot[bot] authored and k8s-infra-cherrypick-robot committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    90ba77f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2459 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2457-to-release-0.16
    
    [release-0.16] 🌱 Bump k8s.io/apiserver from 0.28.0 to 0.28.1
    k8s-ci-robot authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cf1461f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Refactor tests to drop hard otel dependency

    Since v0.16.0 (#2407), there is an import for all users of various
    opentelemetry libraries. This is caused by manager test ->
    pkg/metrics/filters -> k8s.io/apiserver -> otel-go.
    
    The issue is API server users a otel-go library from >1 year ago. This
    makes it impossible to import a modern otel-go library and a modern
    controller-runtime library together.
    
    Go is unable to prune the dependency *even though its only used in
    tests* (TBH, this surprised me!). By moving the tests that use
    `filters` under the `filters` package, though, this drops the required
    dependency on otel-go. Users that import the `filters` package will use
    it, of course, but everyone does not need to.
    
    So basically this refactors tests, but has user facing changes -- fewer
    dependencies are required to import controller-runtime core, allowing
    using the newer controller-runtime with newer otel-go.
    
    In parallel I will attempt to get k/k to update their otel-go version,
    but this will take months to ship at the earliest. IMO, this is worth
    fixing in the meantime as a v0.16.x patch.
    
    (cherry picked from commit d17751f)
    howardjohn committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7d098c8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2465 from howardjohn/16/cp-otel-fix

    [release-0.16] 🐛 Refactor tests to drop hard otel dependency
    k8s-ci-robot authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a597c2c View commit details
    Browse the repository at this point in the history
Loading