🌱 MD: improve replica defaulting for autoscaler by sbueringer · Pull Request #7990 · kubernetes-sigs/cluster-api

sbueringer · 2023-01-24T16:29:33Z

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7293

sbueringer · 2023-01-24T17:20:24Z

/test ?

k8s-ci-robot · 2023-01-24T17:20:26Z

@sbueringer: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-ipv6-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-test-mink8s-main
pull-cluster-api-verify-main

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sbueringer · 2023-01-24T17:20:36Z

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

sbueringer · 2023-01-25T11:57:47Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2023-01-25T15:00:30Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2023-02-01T14:55:37Z

/assign @elmiko @fabriziopandini

sbueringer · 2023-02-06T08:59:35Z

Apologies for the confusion , my query was on Day-2 OP.

On unsetting the replicas field, wont the cluster size shrink and hence disrupt the application running on it. And once it is removed how will the value be reverted to on removing autoscaler ?

Just to mirror it here as well. Quickly talked about it. If during unsetting the replica field the min-size/max-size annotations are set as well, there won't be a disruption as the replica field will just stay the same (as unsetting replicas + defaulting happens in one update-MD call)

sbueringer · 2023-02-06T12:43:25Z

@fabriziopandini @enxebre @elmiko @abhijit-dev82

Removed the default-replicas annotation

elmiko

thanks @sbueringer , i think just one dangling reference to the default-replicas then should be good for me

Signed-off-by: Stefan Büringer [email protected]

sbueringer · 2023-02-06T15:43:51Z

Thx for catching that, fixed!

k8s-ci-robot · 2023-02-06T15:45:53Z

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	`0061757`	link	false	`/test pull-cluster-api-apidiff-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

elmiko

/lgtm

k8s-ci-robot · 2023-02-06T15:46:34Z

LGTM label has been added.

Details

Git tree hash: 4eee904be770f8407cccbca5806815320037f233

abhijit-dev82 · 2023-02-07T05:30:03Z

As discussed we need an bug to track that adding back the "replicas" field should be allowed when the autoscaler annotations are removed.

sbueringer · 2023-02-07T06:45:48Z

As discussed we need an bug to track that adding back the "replicas" field should be allowed when the autoscaler annotations are removed.

I wouldn't call it a bug rather a feature, but feel free to open an issue for it.

fabriziopandini · 2023-02-07T21:58:22Z

/lgtm
/approve

k8s-ci-robot · 2023-02-07T21:58:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2023

k8s-ci-robot requested review from fabriziopandini and stmcginnis January 24, 2023 16:29

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2023

sbueringer changed the title ~~[WIP][DNR][POC] MD: improve replica defaulting for autoscaler~~ [WIP][DNR][POC] 🌱 MD: improve replica defaulting for autoscaler Jan 24, 2023

sbueringer force-pushed the pr-autoscaler-defaulting branch from a85a102 to 776d4eb Compare January 24, 2023 17:18

sbueringer changed the title ~~[WIP][DNR][POC] 🌱 MD: improve replica defaulting for autoscaler~~ [WIP][DNR] 🌱 MD: improve replica defaulting for autoscaler Jan 24, 2023

sbueringer force-pushed the pr-autoscaler-defaulting branch 4 times, most recently from 466942e to f498d4b Compare January 25, 2023 11:19

sbueringer mentioned this pull request Jan 25, 2023

MachineDeployment.spec.replicas defaulting should take into account autoscaler min/max size if defined #7293

Closed

sbueringer force-pushed the pr-autoscaler-defaulting branch from f498d4b to b502d46 Compare January 25, 2023 11:57

sbueringer force-pushed the pr-autoscaler-defaulting branch from b502d46 to 91c1f13 Compare January 25, 2023 15:00

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2023

sbueringer force-pushed the pr-autoscaler-defaulting branch from 91c1f13 to a9ced03 Compare February 1, 2023 14:37

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2023

sbueringer changed the title ~~[WIP][DNR] 🌱 MD: improve replica defaulting for autoscaler~~ 🌱 MD: improve replica defaulting for autoscaler Feb 1, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023

sbueringer force-pushed the pr-autoscaler-defaulting branch 2 times, most recently from fcaf79b to 3255901 Compare February 1, 2023 14:55

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2023

sbueringer force-pushed the pr-autoscaler-defaulting branch from 9d87605 to 1e85904 Compare February 6, 2023 12:38

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023

k8s-ci-robot requested review from elmiko and fabriziopandini February 6, 2023 12:38

sbueringer force-pushed the pr-autoscaler-defaulting branch from 1e85904 to 6520263 Compare February 6, 2023 12:42

sbueringer force-pushed the pr-autoscaler-defaulting branch from 6520263 to f198a76 Compare February 6, 2023 12:45

fabriziopandini mentioned this pull request Feb 6, 2023

🐛 Fix to enable Cluster Autoscaler with Replicas field set in a Classy Cluster #7708

Closed

elmiko reviewed Feb 6, 2023

View reviewed changes

Comment thread api/v1beta1/machinedeployment_webhook.go Resolved

MD: improve replica defaulting for autoscaler

0061757

Signed-off-by: Stefan Büringer [email protected]

sbueringer force-pushed the pr-autoscaler-defaulting branch from f198a76 to 0061757 Compare February 6, 2023 15:43

elmiko reviewed Feb 6, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023

k8s-ci-robot merged commit aecc368 into kubernetes-sigs:main Feb 7, 2023

k8s-ci-robot added this to the v1.4 milestone Feb 7, 2023

sbueringer deleted the pr-autoscaler-defaulting branch February 8, 2023 04:39

sbueringer mentioned this pull request Feb 8, 2023

MachineSet.spec.replicas defaulting should take into account autoscaler min/max size if defined #8085

Closed

This was referenced Mar 1, 2023

cluster-autoscaler CAPI scale up when current number of nodes is less than minSize kubernetes/autoscaler#5267

Closed

Managed Cluster Topology and cluster-autoscaler #8217

Closed

sbueringer mentioned this pull request Jul 3, 2024

📖 Improve godoc of the autoscaler replica field defaulting #10825

Merged

coderabbitai Bot mentioned this pull request Aug 3, 2026

design-proposal: tenant quotas as reservation limits cozystack/community#48

Merged

Conversation

sbueringer commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbueringer commented Jan 24, 2023

Uh oh!

k8s-ci-robot commented Jan 24, 2023

Uh oh!

sbueringer commented Jan 24, 2023

Uh oh!

sbueringer commented Jan 25, 2023

Uh oh!

sbueringer commented Jan 25, 2023

Uh oh!

sbueringer commented Feb 1, 2023

Uh oh!

sbueringer commented Feb 6, 2023

Uh oh!

sbueringer commented Feb 6, 2023

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbueringer commented Feb 6, 2023

Uh oh!

k8s-ci-robot commented Feb 6, 2023

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 6, 2023

Uh oh!

abhijit-dev82 commented Feb 7, 2023

Uh oh!

sbueringer commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabriziopandini commented Feb 7, 2023

Uh oh!

k8s-ci-robot commented Feb 7, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sbueringer commented Jan 24, 2023 •

edited

Loading

sbueringer commented Feb 7, 2023 •

edited

Loading