Skip to content

test: Add shared disk E2E tests that match supported scenario - #1156

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
edreed:edreed-shared-disk-tests
Jan 27, 2022
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
edreed:edreed-shared-disk-tests

Conversation

@edreed

@edreed edreed commented Jan 26, 2022

Copy link
Copy Markdown

What type of PR is this?

/kind test

What this PR does / why we need it:

The existing share disk test cases do not actually test the supported scenario; that is, mounting a shared disk to multiple pods on different nodes as a block device. This PR add E2E test case to the dynamic- and pre-provisioning tests that exercise this scenario.

Which issue(s) this PR fixes:

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@@ -174,7 +174,7 @@ var _ = ginkgo.Describe("Pre-Provisioned", func() {
skipIfUsingInTreeVolumePlugin()

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx This test case doesn't actually test shared disks in a meaningful way or that isn't already covered by other test cases. The previous test case handles creation of a disk with sharing capabilities, and the new test cases test mounting the shared disk to multiple nodes (which implies it can be mounted to one node). Also, this test case doesn't cover the supported scenario of sharing a block volume. I am inclined to simply remove it. Thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, just go ahead remove it

Comment thread test/e2e/pre_provisioning_test.go Resolved
@edreed
edreed force-pushed the edreed-shared-disk-tests branch from 39c29cf to 184c223 Compare January 26, 2022 21:26
@edreed

edreed commented Jan 26, 2022

Copy link
Copy Markdown
Author

/retest

@andyzhangx

Copy link
Copy Markdown
Member

/test all

@andyzhangx andyzhangx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 64cbc04 into kubernetes-sigs:master Jan 27, 2022
@edreed
edreed deleted the edreed-shared-disk-tests branch January 27, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants