Repository navigation
test: Add shared disk E2E tests that match supported scenario - #1156
Conversation
| @@ -174,7 +174,7 @@ var _ = ginkgo.Describe("Pre-Provisioned", func() { | |||
| skipIfUsingInTreeVolumePlugin() | |||
There was a problem hiding this comment.
@andyzhangx This test case doesn't actually test shared disks in a meaningful way or that isn't already covered by other test cases. The previous test case handles creation of a disk with sharing capabilities, and the new test cases test mounting the shared disk to multiple nodes (which implies it can be mounted to one node). Also, this test case doesn't cover the supported scenario of sharing a block volume. I am inclined to simply remove it. Thoughts?
There was a problem hiding this comment.
sure, just go ahead remove it
39c29cf to
184c223
Compare
|
/retest |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, edreed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
What this PR does / why we need it:
The existing share disk test cases do not actually test the supported scenario; that is, mounting a shared disk to multiple pods on different nodes as a block device. This PR add E2E test case to the dynamic- and pre-provisioning tests that exercise this scenario.
Which issue(s) this PR fixes:
Requirements:
Special notes for your reviewer:
Release note: