Skip to content

Support resizing attached azure disk #273

Closed

Description

@andyzhangx

Is your feature request related to a problem? Please describe.

Azure disk could not be resized when it's in "attached" state, we could only resize azure disk when it's in "unattached" state.

Describe the solution you'd like in detail

available from v1.11.0, details: Add azuredisk PV size grow feature

example:

related issues: Resizing the persistent volume in Azure AKS doesn't reflect the change at pod level.

Describe alternatives you've considered

Additional context

/assign

Activity

  1. added
    kind/featureCategorizes issue or PR as related to a new feature.
    priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.
    on Feb 5, 2020
  2. Robert-Stam commented on Feb 12, 2020

    @Robert-Stam

    @andyzhangx : Any news on this? Please provide a ballpark estimate if a solid ETA cannot be provided atm. Thanks in advance! Robert

  3. andyzhangx commented on Feb 13, 2020

    @andyzhangx
    MemberAuthor

    ballpark

    @Robert-Stam azure disk team are still investigating on this since there is a blocking issue, current VM is using VHD, and it does not support dynamic resize.

  4. fejta-bot commented on May 13, 2020

    @fejta-bot

    Issues go stale after 90d of inactivity.
    Mark the issue as fresh with /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle stale

  5. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on May 13, 2020
  6. xamox commented on May 29, 2020

    @xamox

    Any movement on this?

  7. ialidzhikov commented on Jun 7, 2020

    @ialidzhikov
    Contributor

    /remove-lifecycle stale

  8. removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jun 7, 2020
  9. andyzhangx commented on Jun 7, 2020

    @andyzhangx
    MemberAuthor

    Any movement on this?

    @xamox Azure disk team are working on this, rough estimation is end of this year

  10. xamox commented on Jun 8, 2020

    @xamox

    Okay, thanks @andyzhangx

  11. ljeromets commented on Jun 30, 2020

    @ljeromets

    +1, we are also waiting for it.

  12. fejta-bot commented on Sep 28, 2020

    @fejta-bot

    Issues go stale after 90d of inactivity.
    Mark the issue as fresh with /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle stale

  13. 26 remaining items

  14. andyzhangx commented on Jan 20, 2022

    @andyzhangx
    MemberAuthor

    v1.10.0 is already rolled out on AKS in eastus2euap region now, which already supports AzureDiskLiveReisze feature, I just tried, it works

    • register preview feature first:
    az feature show --namespace Microsoft.Compute --name LiveResize
    • supported region list:
    westcentralus
    francesouth
    westindia
    norwaywest
    eastasia
    francecentral
    germanywestcentral
    japanwest
    southafricanorth
    jioindiawest
    canadacentral
    australiacentral
    japaneast
    northeurope
    centralindia
    uaecentral
    switzerlandwest
    brazilsouth
    uksouth
    
    • kubectl edit pvc pvc-name, change spec.resources.requests.storage in PVC config to a larger size
    • and after a while, pvc resize would succeed, e.g.
    describe pvc
    #kubectl describe pvc persistent-storage-statefulset-azuredisk-0
    Name:          persistent-storage-statefulset-azuredisk-0
    Namespace:     default
    StorageClass:  managed-csi
    Status:        Bound
    Volume:        pvc-a8564491-915f-4613-8efb-d02cce0103aa
    Labels:        app=nginx
    Annotations:   pv.kubernetes.io/bind-completed: yes
                   pv.kubernetes.io/bound-by-controller: yes
                   volume.beta.kubernetes.io/storage-class: managed-csi
                   volume.beta.kubernetes.io/storage-provisioner: disk.csi.azure.com
                   volume.kubernetes.io/selected-node: aks-agentpool-14838774-vmss000002
    Finalizers:    [kubernetes.io/pvc-protection]
    Capacity:      10Gi
    Access Modes:  RWO
    VolumeMode:    Filesystem
    Used By:       statefulset-azuredisk-0
    Conditions:
      Type                      Status  LastProbeTime                     LastTransitionTime                Reason  Message
      ----                      ------  -----------------                 ------------------                ------  -------
      FileSystemResizePending   True    Mon, 01 Jan 0001 00:00:00 +0000   Thu, 20 Jan 2022 09:13:00 +0000           Waiting for user to (re-)start a pod to finish file system resize of volume on node.
    Events:
      Type     Reason                    Age                  From                                 Message
      ----     ------                    ----                 ----                                 -------
      Warning  ExternalExpanding         2m19s                volume_expand                        Ignoring the PVC: didn't find a plugin capable of expanding the volume; waiting for an external controller to process this PVC.
      Warning  VolumeResizeFailed        18s (x2 over 79s)    external-resizer disk.csi.azure.com  resize volume "pvc-a8564491-915f-4613-8efb-d02cce0103aa" by resizer "disk.csi.azure.com" failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded
      Normal   Resizing                  16s (x3 over 2m19s)  external-resizer disk.csi.azure.com  External resizer is resizing volume pvc-a8564491-915f-4613-8efb-d02cce0103aa
      Normal   FileSystemResizeRequired  16s                  external-resizer disk.csi.azure.com  Require file system resize of volume on node
    
    
    Conditions:
      Type                      Status  LastProbeTime                     LastTransitionTime                Reason  Message
      ----                      ------  -----------------                 ------------------                ------  -------
      FileSystemResizePending   True    Mon, 01 Jan 0001 00:00:00 +0000   Mon, 24 Jan 2022 03:32:56 +0000           Waiting for user to (re-)start a pod to finish file system resize of volume on node.
    Events:                     <none>
    
    • delete original pod, the pod would get new size after remount immediately
  15. bandesz commented on Jan 24, 2022

    @bandesz

    I've tested this too, but after deleting the pod the new pod gets stuck in containercreating: #1151

  16. andyzhangx commented on Jan 25, 2022

    @andyzhangx
    MemberAuthor

    this feature is still in private preview, and needs to sign up first: https://aka.ms/disksliveresizepreview

  17. bandesz commented on Jan 25, 2022

    @bandesz

    @andyzhangx what would signing up improve on my issue? To clarify I wasn't testing online resizing, just resizing an attached disk, which doesn't work for me using v1.10.0, as the recreated pod couldn't reattach the volume.

  18. bandesz commented on Jan 25, 2022

    @bandesz

    @andyzhangx I had to check and the used subscriptions are signed up for this preview.

  19. andyzhangx commented on Jan 25, 2022

    @andyzhangx
    MemberAuthor

    @andyzhangx what would signing up improve on my issue? To clarify I wasn't testing online resizing, just resizing an attached disk, which doesn't work for me using v1.10.0, as the recreated pod couldn't reattach the volume.

    @bandesz your subs could only support online resize when it's whitelisted by signing up.

  20. andyzhangx commented on Jan 27, 2022

    @andyzhangx
    MemberAuthor

    sorry, I forgot to mention use this command to register LiveResize preview feature:

    az feature show --namespace Microsoft.Compute --name LiveResize
  21. andyzhangx commented on Feb 26, 2022

    @andyzhangx
    MemberAuthor
  22. vgazzola commented on Mar 10, 2022

    @vgazzola

    Hey, for the regions not currently in the preview mentioned in https://docs.microsoft.com/en-us/azure/virtual-machines/linux/expand-disks#expand-an-azure-managed-disk it wouldn't work now, right?
    if correct, do you have an ETA for them? Specifically SwitzerlandNorth

  23. andyzhangx commented on Jun 3, 2022

    @andyzhangx
    MemberAuthor
  24. stoetti commented on Jul 28, 2022

    @stoetti

    @andyzhangx
    Any ETA when this feature will be available without registration?

  25. S0LERA commented on Jun 7, 2023

    @S0LERA

    Any updates of this on OCP?

  26. andyzhangx commented on Jun 7, 2023

    @andyzhangx
    MemberAuthor

    Any updates of this on OCP?

    @S0LERA it should be supported since the underlying azure vm supports data disk online resize now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions