Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: franck-ada
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Here is another occurrence of getheaders:

From my sniff testing, this needs to be changed as well.

http_resp

I was looking at it. this http_resp is an instance of RESTResponse so it should stay as it is

http_resp

I was looking at it. this http_resp is an instance of RESTResponse so it should stay as it is

@franck-ada I was testing an ansible playbook with urllib3 2.6.0 patched like this:

sed -i -e 's/urllib3_response.getheaders()/urllib3_response.headers/' -e 's/urllib3_response.getheader(name, default)/urllib3_response.headers.get(name, default)/' \
    $site_packages/kubernetes/client/rest.py

When trying to delete a configmap that doesn't exist through ansible's k8s task, I still got this error:

TASK [wca-base : Delete configmap in dev] *************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! =>                           
    ansible_facts:                                                                                                             
        discovered_interpreter_python: /home/vagrant/.cache/venv/ansible/bin/python3.12                                        
    changed: false                                                                                                             
    msg: 'Failed to retrieve requested object: ''HTTPResponse'' object has no attribute                                                                                                                                                                       
        ''getheaders'''                                                                                                                                                                                                                                       

I had to add this additional patch to get past this error:

sed -i -e 's/http_resp.getheaders()/http_resp.headers/' \
    $site_packages/kubernetes/client/exceptions.py

Unfortunately, I didn't find a way yet to have ansible print the full stack trace.

the file kubernetes/client/rest.py is generated, the fix needs to be done somewhere else, otherwise, it will be overwritten during next release.

Thanks for working on this! Few things that might help:

The repo already has scripts/rest_urllib_headers.diff which patches exceptions.py to use .headers instead of .getheaders(). Gets applied via apply-hotfixes.sh.

But theres still the RESTResponse.getheaders() method in rest.py (~line 60) that calls self.urllib3_response.getheaders() which will also fail with urllib3 >= 2.6.0. This PR addresses it but as yliaog mentioned rest.py is auto-generated so changes get overwritten.

Maybe we could add another patch file like rest_getheaders_compat.diff? Same pattern as existing hotfixes and survives regeneration. Something like:

--- a/kubernetes/client/rest.py
+++ b/kubernetes/client/rest.py
@@ -58,7 +58,9 @@ class RESTResponse(io.IOBase):

   def getheaders(self):
       """Returns a dictionary of the response headers."""

•    return self.urllib3_response.getheaders()
  

•    if hasattr(self.urllib3_response, 'getheaders'):
  

•        return self.urllib3_response.getheaders()
  

•    return self.urllib3_response.headers.items()
  

This is blocking us from updating to urllib3 >= 2.6.3 which has security fixes. Happy to help test or submit a followup PR for the patch file approach if useful

Thanks for working on this! Few things that might help:

The repo already has scripts/rest_urllib_headers.diff which patches exceptions.py to use .headers instead of .getheaders(). Gets applied via apply-hotfixes.sh.

But theres still the RESTResponse.getheaders() method in rest.py (~line 60) that calls self.urllib3_response.getheaders() which will also fail with urllib3 >= 2.6.0. This PR addresses it but as yliaog mentioned rest.py is auto-generated so changes get overwritten.

Maybe we could add another patch file like rest_getheaders_compat.diff? Same pattern as existing hotfixes and survives regeneration. Something like:

--- a/kubernetes/client/rest.py +++ b/kubernetes/client/rest.py @@ -58,7 +58,9 @@ class RESTResponse(io.IOBase):

   def getheaders(self):
       """Returns a dictionary of the response headers."""

* ```
     return self.urllib3_response.getheaders()
  ```


* ```
     if hasattr(self.urllib3_response, 'getheaders'):
  ```

* ```
         return self.urllib3_response.getheaders()
  ```

* ```
     return self.urllib3_response.headers.items()
  ```

This is blocking us from updating to urllib3 >= 2.6.3 which has security fixes. Happy to help test or submit a followup PR for the patch file approach if useful

Disregard. I found discussion in #2497.