Fix list watch error handling#2217
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CGNonofr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@CGNonofr thank you very much for your contribution 🚀 It seems like the email address you did the commit with is not linked to your GitHub account. This is a requirement for EasyCLA to pass which is required to merge this PR. Also it would be very nice if you could add a test to make sure this we keep this behavior in the future (and that it works as expected of course). |
|
As per my last PR, I don't think I'll want to sign the CLA I authorize you to close that PR and include the fix in the way you want I don't have the time right now to investigate how to implement such test, maybe in the next weeks |
|
Created this issue to track: Closing this PR. |
when listFn returns an error, the ListWatch is broken and no ERROR event is sent