Skip to content

Add ApiClient in ClientBuilder#4152

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
iseki0:feat/client-builder-add-api-client
Jul 23, 2025
Merged

Add ApiClient in ClientBuilder#4152
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
iseki0:feat/client-builder-add-api-client

Conversation

@iseki0
Copy link
Contributor

@iseki0 iseki0 commented Jul 21, 2025

Since the ApiClient has another constructor: apiClient(OkHttpClient). It's useful to allowing user customize the argument. OkHttp also recommend user to reuse the client instance(to sharing the internal dispatchers and connection pool).

@iseki0
Add ApiClient in ClientBuilder
407e1b7 
Since the ApiClient has another constructor: apiClient(OkHttpClient).
It's useful to allowing user customize the argument.
OkHttp also recommend user to reuse the client instance(to sharing the
internal dispatchers and connection pool).

Signed-off-by: iseki <[email protected]>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 21, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 21, 2025

Welcome @iseki0!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2025
@brendandburns
Copy link
Contributor

brendandburns commented Jul 23, 2025

/lgtm
/approve

Thanks for the PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, iseki0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit a60ff25 into kubernetes-client:master Jul 23, 2025
18 checks passed
@iseki0 iseki0 deleted the feat/client-builder-add-api-client branch July 29, 2025 04:43
@iseki0
Copy link
Contributor Author

iseki0 commented Aug 25, 2025

Consider make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iseki0 @k8s-ci-robot @brendandburns

Comments