Skip to content

fix: correct fieldManager parameter in makeClusterCreateCallBuilder#4140

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
zongzewu23:fix/cluster-create-fieldmanager-typo
Jul 23, 2025
Merged

fix: correct fieldManager parameter in makeClusterCreateCallBuilder#4140
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
zongzewu23:fix/cluster-create-fieldmanager-typo

Conversation

@zongzewu23
Copy link
Contributor

@zongzewu23 zongzewu23 commented Jul 17, 2025

Fix typo where .dryRun() was called twice instead of .fieldManager() in GenericKubernetesApi.makeClusterCreateCallBuilder method.

Fixes #4138

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 17, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: zongzewu23 / name: Zongze Wu (87886d5)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 17, 2025

Welcome @zongzewu23!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 17, 2025
@zongzewu23
fix: correct fieldManager parameter in makeClusterCreateCallBuilder
87886d5 
Fix typo where .dryRun() was called twice instead of .fieldManager()
in GenericKubernetesApi.makeClusterCreateCallBuilder method.
@zongzewu23 zongzewu23 force-pushed the fix/cluster-create-fieldmanager-typo branch from 3a8a1e8 to 87886d5 Compare July 17, 2025 07:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 17, 2025
@brendandburns
Copy link
Contributor

brendandburns commented Jul 23, 2025

/lgtm
/approve

Thanks! (bonus points if we add a unit test for this :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, zongzewu23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6ef8834 into kubernetes-client:master Jul 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GenericKubernetesApi.makeClusterCreateCallBuilder

3 participants

@zongzewu23 @k8s-ci-robot @brendandburns

Comments