Skip to content

fix: add missing continue token when build cluster list call#3930

Merged
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
cyrilcsr:dev
Feb 19, 2025
Merged

fix: add missing continue token when build cluster list call#3930
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
cyrilcsr:dev

Conversation

@cyrilcsr
Copy link
Contributor

@cyrilcsr cyrilcsr commented Feb 19, 2025

Hi, there
This pr fixes missing continue token when listing resources without namespace specified. This will cause when passing continue token, we always get the result of first page. Seems in makeClusterListCallBuilder() the continue param from ListOptions is never used.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2025

Welcome @cyrilcsr!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2025
@brendandburns
Copy link
Contributor

brendandburns commented Feb 19, 2025

Looks good. It would be great to add unit tests so that we don't regress in the future.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@cyrilcsr
Copy link
Contributor Author

cyrilcsr commented Feb 19, 2025

Looks good. It would be great to add unit tests so that we don't regress in the future.

I have added a few unit tests for building list call. I'm not sure which test file should I put these unit tests, so I created a new GenericKubernetesListApiTest file which refers to the GenericKubernetesGetApiTest file. Please take a look.

yue9944882
yue9944882 reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyrilcsr, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit c8daa58 into kubernetes-client:master Feb 19, 2025
2 checks passed
@cyrilcsr cyrilcsr deleted the dev branch February 20, 2025 01:17
@yue9944882 yue9944882 mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@yue9944882 yue9944882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrilcsr @k8s-ci-robot @brendandburns @yue9944882

Comments