Skip to content

fix(typescript): enable importFileExtension option#275

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
cjihrig:extensions
Dec 3, 2024
Merged

fix(typescript): enable importFileExtension option#275
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
cjihrig:extensions

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Dec 3, 2024

This commit updates the TypeScript generator options to include importFileExtension. This is done in order to support ESM in the JavaScript client, as ESM requires explicit extensions.

Refs: kubernetes-client/javascript#2062

@cjihrig
fix(typescript): enable importFileExtension option
f65fa34 
This commit updates the TypeScript generator options to include
importFileExtension. This is done in order to support ESM in
the JavaScript client, as ESM requires explicit extensions.

Refs: kubernetes-client/javascript#2062
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 3, 2024

Welcome @cjihrig!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2024
@cjihrig cjihrig mentioned this pull request Dec 3, 2024
Merged
cjihrig added a commit to cjihrig/javascript that referenced this pull request Dec 3, 2024
@cjihrig
gen: regenerate with importFileExtension option
7f88044 
This is necessary for ESM support.

Refs: kubernetes-client#2062
Refs: kubernetes-client/gen#275
@cjihrig cjihrig mentioned this pull request Dec 3, 2024
Merged
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Dec 3, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit b461333 into kubernetes-client:master Dec 3, 2024
@cjihrig cjihrig deleted the extensions branch December 3, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliaog yliaog Awaiting requested review from yliaog

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cjihrig @k8s-ci-robot @brendandburns