Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContainersReady status for Pods #9197

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Add ContainersReady status for Pods #9197

merged 1 commit into from
Jun 25, 2018

Conversation

lucperkins
Copy link
Contributor

This PR addresses issue #9099. This PR is currently a WIP while I wait on information regarding appropriate usage.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2018
@lucperkins lucperkins mentioned this pull request Jun 22, 2018
Merged
@lucperkins lucperkins requested a review from freehan June 22, 2018 00:28
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 22, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4d34ca3

https://deploy-preview-9197--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1338ecb

https://deploy-preview-9197--kubernetes-io-master-staging.netlify.com

tengqm
tengqm reviewed Jun 22, 2018
View reviewed changes
content/en/docs/concepts/workloads/pods/pod-lifecycle.md Outdated
due to an error in communicating with the host of the Pod.
Value | Description
:-----|:-----------
`ContainersReady` | All Containers in the Pod are currently ready
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This is not a Phase, it is a Condition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right. I've fixed this and expanded the section on Pod conditions.

tengqm
tengqm reviewed Jun 22, 2018
View reviewed changes
content/en/docs/tutorials/stateful-application/cassandra.md Outdated

{{< code file="cassandra/cassandra-statefulset.yaml" >}}

## Validating The Cassandra StatefulSet

1. Get the Cassandra StatefulSet:

kubectl get statefulset cassandra
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following indentations are breaking the numbered list. Please see preview result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this doc were included by accident. I've removed these changes from this PR.

@lucperkins lucperkins changed the title [WIP] Add ContainersReady status for Pods to [WIP] Add ContainersReady status for Pods Jun 22, 2018
@lucperkins lucperkins changed the title [WIP] Add ContainersReady status for Pods Add ContainersReady status for Pods Jun 22, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 22, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2018
@lucperkins lucperkins requested a review from zacharysarah June 22, 2018 19:12
@tengqm
Copy link
Contributor

tengqm commented Jun 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2018
@zacharysarah
Copy link
Contributor

@lucperkins Thanks for taking a crack at this. Ultimately I'd like to see a more thorough pass for style guide consistency (for example, de-bullet and reorganize the Pod conditions and Example states sections), but this PR represents an iterative first step with formatting updates. 👍

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit bede518 into kubernetes:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@ahmetb ahmetb Awaiting requested review from ahmetb

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@freehan freehan Awaiting requested review from freehan

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@zacharysarah zacharysarah

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucperkins @k8sio-netlify-preview-bot @tengqm @zacharysarah @k8s-ci-robot